Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: "/" key should place the cursor on the search bar on the homepage and search page #42819

Closed
jeanbza opened this issue Nov 25, 2020 · 6 comments
Closed

x/pkgsite: "/" key should place the cursor on the search bar on the homepage and search page #42819

jeanbza opened this issue Nov 25, 2020 · 6 comments
Labels
FeatureRequest FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
pkgsite/frontend

Comments

@jeanbza
Copy link
Member

jeanbza commented Nov 25, 2020 •
edited

This is a feature request to add similar behavior as youtube, drive, etc.
@gopherbot gopherbot added this to the Unreleased milestone Nov 25, 2020
@jba jba added FeatureRequest NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 25, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Nov 25, 2020
@julieqiu
Copy link
Member

This should have already been fixed in #36805. @jadekler - could you confirm if that is the feature you are requesting?

@jeanbza
Copy link
Member Author

jeanbza commented Nov 30, 2020

Yes, that is the feature. It appears to have regressed.

@julieqiu
Copy link
Member

The feature works for me on Chrome 86 on macOS (Catalina). Which URL are you looking at and what browser are you using?

@jeanbza
Copy link
Member Author

jeanbza commented Nov 30, 2020 •
edited

Ah, it does indeed work on a specific package. Apologies.

However, it does not work on the homepage (pkg.go.dev). Not sure if this bug should be re-purposed to address that specific page?

edit: I'm using glinux (debian-ish for non-googlers) on chrome.

@julieqiu julieqiu changed the title x/pkgsite: the "/" key places the cursor on the search bar x/pkgsite: "/" key places the cursor on the search bar on the homepage Nov 30, 2020
@julieqiu
Copy link
Member

Not sure if this bug should be re-purposed to address that specific page?

Yup! Updated the title.

@julieqiu julieqiu changed the title x/pkgsite: "/" key places the cursor on the search bar on the homepage x/pkgsite: "/" key should place the cursor on the search bar on the homepage and search page Dec 1, 2020
@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. help wanted Suggested Issues that may be good for new contributors looking for work to do. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Dec 1, 2020
@julieqiu
Copy link
Member

julieqiu commented Dec 1, 2020

There's actually already an issue filed for this. Closing as a duplicate of #42704.

@julieqiu julieqiu closed this as completed Dec 1, 2020
@golang golang locked and limited conversation to collaborators Dec 1, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@jeanbza @hyangah @julieqiu @gopherbot @jba