Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: explore UX of fillstruct for partially populated nested structs #42818

Open
jeanbza opened this issue Nov 24, 2020 · 0 comments
Open

x/tools/gopls: explore UX of fillstruct for partially populated nested structs #42818

jeanbza opened this issue Nov 24, 2020 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@jeanbza
Copy link
Member

jeanbza commented Nov 24, 2020

Continuation of #39804, in which in cl262018 we introduce basic support for partially filled structs: how should this work for nested structs? Should all levels of the nested structs populate? Or only one level? If one level, which level, when the cursor is between two of the nested struct levels, like,

f := Foo{
  Bar: {}, // cursor is on the closing bracket: fill Foo, or Bar, or both?
}
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 24, 2020
@suzmue suzmue mentioned this issue Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
3 participants
@jeanbza @stamblerre @gopherbot