Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: change "Toggle gc details" to show/hide #42812

Closed
stamblerre opened this issue Nov 24, 2020 · 1 comment
Closed

x/tools/gopls: change "Toggle gc details" to show/hide #42812

stamblerre opened this issue Nov 24, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

It's not always clear which package you've enabled GC details for, so you may not know if it's on or off--it might be easier if the codelens was "Show GC details" and "Hide GC details".

/cc @pjweinb

@stamblerre stamblerre added this to the gopls/vscode-go milestone Nov 24, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 24, 2020
@stamblerre
Copy link
Contributor Author

Not doable because codelenses only update on file change.

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Jun 28, 2021
@golang golang locked and limited conversation to collaborators Jun 28, 2022
gopherbot pushed a commit to golang/tools that referenced this issue Jan 14, 2025
This CL improves the usability of the "Toggle compiler optimization
details" code action by:

- making it work for _test.go files too (by running "go test -c"
  instead of "go build");
- changing the flag to be per directory, not per metadata.Package,
  as this led to confusing behaviour w.r.t. in-package test files.
- presenting specific "Show"/"Hide" command titles depending on
  the current state, instead of the vague "Toggle".

It includes a test for all the new functionality.

Also, document the "transitively error free" requirement.

Fixes golang/go#71106
Fixes golang/go#42812 (amusingly)

Change-Id: I842d7e3f53d1c4f0e94b8741ca792c3d999d6ff3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/640395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants