-
Notifications
You must be signed in to change notification settings - Fork 18k
image/png: reading an image with binary transparency returns wrong error #4278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Owner changed to @nigeltao. |
I don't know, I think I modified one of my programs that uses libpng, then used <https://github.com/jteeuwen/go-bindata>;. The goal was to make a minimal testcase for this bug. Any non-paletted image with a tRNS chunk will do. There are examples in PngSuite <http://www.schaik.com/pngsuite/PngSuite-2011apr25.tgz>;, such as tbrn2c08.png. |
The provided sample image is not a valid PNG image. The mentioned tbrn2c08.png of http://www.schaik.com/pngsuite/PngSuite-2011apr25.tgz is also invalid. The spec is pretty clear about tRNS has to come after PLTE and before IDAT. See: http://www.libpng.org/pub/png/spec/iso/index-object.html#5ChunkOrdering It seems as if this was not check in libpng prior to 1.6.0 but is enforced now. See http://sourceforge.net/p/libpng/code/ci/0da9cf38cd55178e6dabacf720fa21741bc50cd5/tree/pngrutil.c#l1001 So: Not a bug. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by jsummers3456:
The text was updated successfully, but these errors were encountered: