Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: offer completions with automatic casts #42764

Closed
muirdm opened this issue Nov 21, 2020 · 1 comment
Closed

x/tools/gopls: offer completions with automatic casts #42764

muirdm opened this issue Nov 21, 2020 · 1 comment
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@muirdm
Copy link

muirdm commented Nov 21, 2020

var myInt int
var _ float64 = my<>

It would be nice if completing at <> offered float64(myInt) as a completion. This comes up often for me when passing an int to something that wants an int64, float64, etc. Another common case where it would be useful:

func doSomething(d time.Duration) {}

for i := 0;  < 10; i++ {
  doSomething(i<>)
}

It would be useful if <> offered time.Duration(i) to help you towards time.Duration(i) * time.Millisecond, or whatever.

Similarly, but maybe less common:

var myIntf interface{}
var _ float64 = my<>

It might be nice if completing at <> offered myIntf.(float64) as a completion. Unchecked type assertions are relatively rare, though, so perhaps not worth the effort.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 21, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 21, 2020
@gopherbot
Copy link

Change https://golang.org/cl/272286 mentions this issue: internal/lsp: offer type converted completion candidates

@golang golang locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants