Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: diagnose go.mod error message is only a logged warning, not diagnostic #42730

Closed
stamblerre opened this issue Nov 19, 2020 · 1 comment
Closed

x/tools/gopls: diagnose go.mod error message is only a logged warning, not diagnostic #42730

stamblerre opened this issue Nov 19, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
vscode-go: gopls by default
Milestone
gopls/v0.6.0

Comments

@stamblerre
Copy link
Contributor

See https://github.com/golang/tools/blob/c0d5e8918928cb7629f88b55682d154ba05fe942/internal/lsp/diagnostics.go#L172.
We got an error report on Slack where the error message was completely swallowed and only visible in logs.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 19, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 19, 2020
@stamblerre
Copy link
Contributor Author

I believe this has been resolved now that ErrorsForMod expands ModTidy errors to source error lists.

vscode-go: gopls by default automation moved this from Critical to Done Dec 6, 2020
@golang golang locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
gopls/v0.6.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot