Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: content overflows horizontally on startpage using safari #42718

Closed
emmanuelay opened this issue Nov 19, 2020 · 3 comments
Closed

x/pkgsite: content overflows horizontally on startpage using safari #42718

emmanuelay opened this issue Nov 19, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite

Comments

@emmanuelay
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15

Screenshot

Skärmavbild 2020-11-19 kl  08 44 31

What did you do?

Resize the window once.

What did you expect to see?

I expected a normal responsive behavior.

What did you see instead?

Scrollbars indicating there is a horizontal overflow.
After looking through the elements of the startpage I found the culprit is in the class .Questions, more specific this style:

width: 100vw;

..when disabled, the overflow stops appearing.

@gopherbot gopherbot added this to the Unreleased milestone Nov 19, 2020
@Omkar76
Copy link

Omkar76 commented Nov 19, 2020

Seeing same issue on firefox and chrome

@Omkar76
Copy link

Omkar76 commented Nov 19, 2020

The problem was caused by oversized .Questions div (faq). Removing width:100vw solved the problem. I have made a PR for the same golang/pkgsite#18

@jamalc jamalc modified the milestones: Unreleased, pkgsite/frontend Nov 19, 2020
@jamalc jamalc added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 19, 2020
@gopherbot
Copy link

Change https://golang.org/cl/271518 mentions this issue: content/static/css: fix overflow on homepage

@golang golang locked and limited conversation to collaborators Nov 23, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants