Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: use squirrel where appropriate #42708

Closed
jba opened this issue Nov 18, 2020 · 6 comments
Closed

x/pkgsite: use squirrel where appropriate #42708

jba opened this issue Nov 18, 2020 · 6 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@jba
Copy link
Contributor

jba commented Nov 18, 2020

Squirrel may help with some of our dynamically constructed queries. Try it out.
@jba jba added this to the pkgsite/unplanned milestone Nov 18, 2020
@julieqiu
Copy link
Member

Thanks @johanbrandhorst for the suggestion! We got this idea from your GopherCon talk: https://www.gophercon.com/agenda/session/227419.

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 18, 2020
@gopherbot
Copy link

Change https://golang.org/cl/271398 mentions this issue: internal/postgres: use squirrel in isLatestVersion

@gopherbot
Copy link

Change https://golang.org/cl/271397 mentions this issue: internal/postgres: use squirrel in GetLatestMajorVersion

@gopherbot
Copy link

Change https://golang.org/cl/271379 mentions this issue: internal/postgres: use squirrel in GetUnitMeta

gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 23, 2020
@julieqiu
internal/postgres: use squirrel in GetUnitMeta
ee99d75 
github.com/Masterminds/squirrel is now used to build the query for
GetUnitMeta.

For golang/go#42708

Change-Id: I91ce1c205739445e1bccfe9549d232b49337b999
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271379
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 24, 2020
@julieqiu
internal/postgres: use squirrel in GetLatestMajorVersion
451cdd3 
github.com/Masterminds/squirrel is now used to build the query for
GetLatestMajorVersion.

For golang/go#42708

Change-Id: I52cc4ac0b5083040732bdf8da60495ac61426a4c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271397
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 25, 2020
@julieqiu
internal/postgres: use squirrel in isLatestVersion
03b1a6d 
github.com/Masterminds/squirrel is now used to build the query for
isLatestVersion.

For golang/go#42708

Change-Id: I61b1d82cecbf147ffd929ac807da26d6b06d5c18
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/271398
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Johan Brandhorst <johan.brandhorst@gmail.com>
@julieqiu
Copy link
Member

It might make sense to check out https://github.com/kyleconroy/sqlc instead.

@julieqiu
Copy link
Member

Closing this issue since we are now using squirrel in several places in the codebase.

@golang golang locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba