Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: create focus indicators to replace browser defaults #42698

Closed
jamalc opened this issue Nov 18, 2020 · 2 comments
Closed

x/pkgsite: create focus indicators to replace browser defaults #42698

jamalc opened this issue Nov 18, 2020 · 2 comments
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite UX Issues that involve UXD/UXR input
Milestone
pkgsite/frontend

Comments

@jamalc
Copy link

jamalc commented Nov 18, 2020

The default style and behavior of focus indicators is set by browsers to make websites more accessible to keyboard only users and those with reduced vision. Their styles vary across browsers and sometimes clash with pkgsite's layout (#40759) and design (#42583). Focus visibility is a WCAG requirement so we can remove the default outlines but we'll need replacement indicators.

When replaced by a box shadow :focus {outline: transparent; } should be used in place of :focus {outline: none; } because box shadows will not appear on some high contrast screens and transparent focus will.

/cc @Joanne881107 @fflewddur for product / UX input
@jamalc jamalc added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite labels Nov 18, 2020
@jamalc jamalc added this to the pkgsite/frontend milestone Nov 18, 2020
@jamalc jamalc mentioned this issue Nov 18, 2020
Closed
@jamalc jamalc added UX Issues that involve UXD/UXR input website labels Nov 18, 2020
@jamalc jamalc mentioned this issue Nov 18, 2020
Closed
@jamalc jamalc mentioned this issue Dec 7, 2020
Closed
@julieqiu julieqiu removed the website label Dec 21, 2020
@julieqiu
Copy link
Member

/cc @georgehu for input on the UI for focus visibility

@jamalc jamalc assigned jamalc and unassigned georgehu May 11, 2021
@jamalc
Copy link
Author

jamalc commented Jul 14, 2021

Done.

@jamalc jamalc closed this as completed Jul 14, 2021
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@georgehu @hyangah @julieqiu @gopherbot @jamalc