Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Forks are counted as imports #42697

Open
lu4p opened this issue Nov 18, 2020 · 1 comment
Open

x/pkgsite: Forks are counted as imports #42697

lu4p opened this issue Nov 18, 2020 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@lu4p
Copy link

lu4p commented Nov 18, 2020 •
edited

What is the URL of the page with the issue?

Example: https://pkg.go.dev/github.com/lu4p/binclude?tab=importedby

Screenshot

Screenshot_2020-11-18 binclude · pkg go dev(1)

How to reproduce

Create a repo on github with a subpackage which imports the root package:

Example:

github.com/user/foo - root package
github.com/user/foo/cmd/foo - imports foo

Then fork the repo with another user.

What did you expect to see?

Package has no importers.

What did you see instead?

Package is imported by the fork.
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2020
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 18, 2020
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Nov 18, 2020
@bcmills
Copy link
Contributor

bcmills commented Nov 18, 2020 •
edited

The pkgsite cross-reference appears to be correct. If you click through the link, you'll find exactly one version of that module (v0.0.0-20200630183912-8068350e017e), and at that version it really is a distinct module that imports packages from the upstream module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @jamalc @lu4p