Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: set experimentalPackageCacheKey to true by default #42692

Closed
stamblerre opened this issue Nov 18, 2020 · 3 comments
Closed

x/tools/gopls: set experimentalPackageCacheKey to true by default #42692

stamblerre opened this issue Nov 18, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

This is an experimental setting that does not appear to have had any negative consequences (no user bug reports that can be attributed to it). We should enable it by default in the next release.

/cc @findleyr

@stamblerre stamblerre added this to the gopls/v0.5.4 milestone Nov 18, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 18, 2020
@stamblerre stamblerre changed the title x/tools/gopls: set experimentalCacheKey to true by default x/tools/gopls: set experimentalPackageCacheKey to true by default Nov 18, 2020
@gopherbot
Copy link

Change https://golang.org/cl/271478 mentions this issue: internal/lsp/source: set experimentalPackageCacheKey to true by default

@stamblerre stamblerre self-assigned this Nov 19, 2020
@golang golang locked and limited conversation to collaborators Nov 19, 2021
@findleyr findleyr modified the milestones: gopls/v0.5.4, gopls/v0.12.0 Jan 13, 2023
@findleyr
Copy link
Contributor

In order to do this, we need to eliminate the dependence on packages.Config, by pre-processing go/packages error.

I am working on doing this.

@findleyr findleyr reopened this Jan 13, 2023
@golang golang unlocked this conversation Jan 13, 2023
@findleyr
Copy link
Contributor

Err, wrong issue. This was done.

@findleyr findleyr modified the milestones: gopls/v0.12.0, gopls/v0.5.4 Jan 17, 2023
@golang golang locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants