Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add ?utm_source=gopls to pkg.go.dev links #42602

Closed
stamblerre opened this issue Nov 13, 2020 · 3 comments
Closed

x/tools/gopls: add ?utm_source=gopls to pkg.go.dev links #42602

stamblerre opened this issue Nov 13, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.4

Comments

@stamblerre
Copy link
Contributor

/cc @julieqiu
@stamblerre stamblerre added this to the gopls/v0.5.4 milestone Nov 13, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 13, 2020
@stamblerre stamblerre self-assigned this Nov 13, 2020
@gopherbot
Copy link

Change https://golang.org/cl/270097 mentions this issue: internal/lsp: add ?utm_source=gopls to links to pkg.go.dev

@gopherbot
Copy link

Change https://golang.org/cl/270263 mentions this issue: internal/middleware: strip utm_source for gopls

@gopherbot
Copy link

Change https://golang.org/cl/270800 mentions this issue: content/static: strip known utm sources on page load

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 26, 2021
@julieqiu @jba
content/static: strip known utm sources on page load
4da3fcf 
Requests originating from gopls and redirected from godoc.org have a
"utm_source=gopls" and "utm_source=godoc" query param in the URL,
respectively.

If we see this, we will strip the query param on page load, so that so
that it doesn’t remain in all our URLs coming from these sites.

This is done to page load so that requests are still sent to GA with
these utm_sources intact.

For golang/go#42602

Change-Id: I63defcb50ba54b1e476de0f0db63c23494000046
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/270800
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@golang golang locked and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.4
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot