Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/work: TestSharedLibName failure on Windows with ERROR_SHARING_VIOLATION #42588

Closed
bcmills opened this issue Nov 13, 2020 · 1 comment
Closed

cmd/go/internal/work: TestSharedLibName failure on Windows with ERROR_SHARING_VIOLATION #42588

bcmills opened this issue Nov 13, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 13, 2020

https://storage.googleapis.com/go-build-log/9ccd0db2/windows-amd64-2016_51fcf464.log

--- FAIL: TestSharedLibName (0.00s)
    build_test.go:183: remove C:\Users\gopher\AppData\Local\Temp\1\gopath209112075\src\somelib: The process cannot access the file because it is being used by another process.
FAIL
FAIL	cmd/go/internal/work	0.041s

See previously #15124 (@alexbrainman) and #32188.

As a workaround, we might be able to replace the call to os.RemoveAll in this test with a call to the robustio.RemoveAll function added for #32188, but it's not obvious to me why os.RemoveAll would fail in this case.

CC @jayconrod @matloob @networkimprov @zx2c4
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 13, 2020
@bcmills bcmills added this to the Backlog milestone Nov 13, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Nov 13, 2020

Actually, the test failed on two different Windows builders at that CL (https://golang.org/cl/268261), so it appears this isn't a flake after all — it's probably something related to the change itself. Sorry for the noise!

@bcmills bcmills closed this as completed Nov 13, 2020
@golang golang locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot