Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: allow flags in CGO_LDFLAGS environment variable not in security allowlist [1.14 backport] #42566

Closed
gopherbot opened this issue Nov 12, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #42565 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open backport issues.

This is a usability regression introduced by the security fix for #42556. The security fix was applied to all release branches, and we should follow up with a fix for this usability regression.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 12, 2020
@gopherbot gopherbot added this to the Go1.14.13 milestone Nov 12, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/270080 mentions this issue: [release-branch.go1.14] cmd/go: permit CGO_LDFLAGS to appear in //go:ldflag

@gopherbot
Copy link
Author

Closed by merging 7177852 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Nov 16, 2020
…ldflag

For #42565
Fixes #42566

Change-Id: If7cf39905d124dbd54dfac6a53ee38270498efed
Reviewed-on: https://go-review.googlesource.com/c/go/+/269818
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 782cf56)
Reviewed-on: https://go-review.googlesource.com/c/go/+/270080
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Dec 3, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 3, 2020
@golang golang locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants