os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch #42542

bcmills · 2020-11-12T14:42:39Z

cmd/go calls os.Exit with a nonzero status code on failure:

go/src/cmd/go/internal/base/base.go

Line 102 in 0e953ad

os.Exit(exitStatus)

The cmd/go tests use os/exec to execute subprocesses, and check them for the expected exit status:

go/src/cmd/go/script_test.go

Line 1183 in e75aef8

waitErr := cmd.Wait()

Tests that expect nonzero exit status are failing frequently on the openbsd-arm64-jsing builder (CC @4a6f656c), which suggests that either os.Exit is not consistently causing the process to exit with the correct status, or (*os.Process).Wait is not consistently reporting the correct status.

It is not clear to me whether this is a bug in the Go standard library or the OpenBSD kernel.

The text was updated successfully, but these errors were encountered:

bcmills · 2020-11-12T14:43:39Z

@golang/release, you might consider marking this builder with a KnownIssue until this is resolved. Based on the status of #31656, it appears that this port is incomplete and not yet supported.

4a6f656c · 2020-11-12T18:32:54Z

@golang/release, you might consider marking this builder with a KnownIssue until this is resolved. Based on the status of #31656, it appears that this port is incomplete and not yet supported.

FWIW the port is complete (has been for a long time) - the only reason it is not yet supported was due to the lack of a builder, which has now been addressed.

Re this specific issue, the failures are all TestScript... a couple of interesting things to note - firstly, this seems to have started when the builder was upgraded and some of the binaries were not (which I've just fixed). Having said that, I'm pretty sure that some of the TestScript tests are relying on the local Go binary (/usr/local/go/bin/go in this case), rather than the Go binary that has been built from source (probably not what we want):

$ kdump -HT | grep NAMI | grep bin/go 
 28299/455478  go.test  1605204346.818164 NAMI  "/usr/local/go/bin/go"
 29314/257479  go.test  1605204346.830077 NAMI  "/usr/local/go/bin/go"
 29314/257479  go       1605204346.875199 NAMI  "/usr/local/go/bin/go"
 53698/463669  go.test  1605204346.973705 NAMI  "/usr/local/go/bin/go"
 98216/426375  go.test  1605204347.116089 NAMI  "/usr/local/go/bin/go"
 59520/594260  go.test  1605204347.253691 NAMI  "/usr/local/go/bin/go"
...
 | | |-+= 60121 joel ./go.test -test.run=TestScript
 | | | |-+- 72510 joel /tmp/cmd-go-test-091599085/tmpdir936823144/testbin/go test -v multimain
 | | | | \--- 01312 joel (vet)
 | | | |-+- 26114 joel /tmp/cmd-go-test-091599085/tmpdir936823144/testbin/go build rsc.io/CGO
 | | | | \--- 51018 joel cc -I /tmp/cmd-go-test-091599085/tmpdir936823144/script-mod_case_cgo/gopath/pkg/mod/rsc.io/!c!g!o@v1.0.0 -fPIC -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/t
 | | | |--- 59076 joel /tmp/cmd-go-test-091599085/tmpdir936823144/testbin/go vet m/onlycgo
 | | | \-+- 30712 joel /tmp/cmd-go-test-091599085/tmpdir936823144/testbin/go install main_test
 | | |   \--- 38529 joel /usr/local/go/pkg/tool/openbsd_arm64/link -o /tmp/cmd-go-test-091599085/tmpdir936823144/script-test_main_archive/tmp/go-build539908792/b001/exe/a.out -importcfg /tmp/cmd-go-test-091599085/tmpdir93682314

If my suspicion is correct, this will clear as the next builds occur.

4a6f656c · 2020-11-13T14:02:15Z

Interesting - the OpenBSD 6.8 openbsd/386 and openbsd/amd64 new builders are showing the same symptoms, so this is presumably not openbsd/arm64 specific.

4a6f656c · 2020-11-16T16:04:33Z

I've confirmed that this is an issue with the OpenBSD kernel - a fix has been manually applied to the openbsd/arm64 builder and I'm hoping that a syspatch can be made available for it soon.

4a6f656c · 2020-12-10T15:32:49Z

@dmitshur OpenBSD have released an errata for this issue - this should be picked up via syspatch if the OpenBSD 6.8 builder images are recreated.

dmitshur · 2020-12-10T16:12:18Z

@4a6f656c Thank you for letting me know. I'll create new versions of the openbsd-amd64-68 and openbsd-386-68 images, and post an update in #35712.

gopherbot · 2020-12-10T21:26:10Z

Change https://golang.org/cl/277115 mentions this issue: dashboard: update OpenBSD 6.8 images with 009_exit syspatch

For golang/go#35712. Updates golang/go#42542. Updates golang/go#42426. Change-Id: Ifbdd025b8d1708e715ba312c438f391e1aeaeff8 Reviewed-on: https://go-review.googlesource.com/c/build/+/277115 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Joel Sing <joel@sing.id.au>

gopherbot · 2020-12-16T17:22:55Z

Change https://golang.org/cl/278732 mentions this issue: env/openbsd-amd64: syspatch on first boot

syspatch is currently being invoked at the end of the installation, which means we're trying to patch the installation ramdisk kernel, rather than the generic kernel. Instead, invoke syspatch during the first boot of the generic kernel. Move pkg_add as well, since that is also generally safer to run outside of the installation. Update golang/go#35712 Update golang/go#42542 Change-Id: Icbb384816de5859078a0183919626d223fb0060f Reviewed-on: https://go-review.googlesource.com/c/build/+/278732 Trust: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

gopherbot · 2020-12-18T05:05:36Z

Change https://golang.org/cl/279134 mentions this issue: dashboard: update OpenBSD 6.8 images with 009_exit syspatch, take 2

These images were regenerated after the fix in CL 278732. For golang/go#35712. Updates golang/go#42542. Updates golang/go#42426. Change-Id: Ib9c9dc316e4f68e7fed2cafe5400942a94ba8fd2 Reviewed-on: https://go-review.googlesource.com/c/build/+/279134 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Joel Sing <joel@sing.id.au>

gopherbot · 2020-12-21T19:29:05Z

Change https://golang.org/cl/279512 mentions this issue: dashboard: promote OpenBSD 6.8 builders to be default

dmitshur · 2020-12-22T23:11:01Z

I understand this was determined to be an issue in the OpenBSD kernel, which should be resolved via the 009_exit syspatch. Can this issue be closed, or is there more left to do here?

The known issue with OpenBSD 6.8 builders appears to be resolved via CL 278732 and CL 279134. Promote them to the primary OpenBSD post-submit builders and TryBots. Having test coverage from OpenBSD 6.8 and 6.4 builders gives us us more confidence that Go works on supported OpenBSD versions (which are 6.8 and 6.7 at this time, per past policy decision in https://golang.org/issue/15227#issuecomment-293319876). Reduce numTryTestHelpers from 5 to 4 based on some data from golang.org/issue/37439 showing that going from 3 to 5 helpers doesn't make a significant difference. We can adjust further if we learn that OpenBSD TryBots become the bottleneck. Fixes golang/go#35712. For golang/go#42542. For golang/go#42064. Updates golang/go#42426. Change-Id: Id2fa4be7c3161f89752c1428146846fe06ca63db Reviewed-on: https://go-review.googlesource.com/c/build/+/279512 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org>

4a6f656c · 2021-01-22T19:15:31Z

I understand this was determined to be an issue in the OpenBSD kernel, which should be resolved via the 009_exit syspatch. Can this issue be closed, or is there more left to do here?

@dmitshur - correct, as far as I'm concerned this can be closed.

dmitshur · 2021-01-22T20:15:24Z

Thank you for your work on this Joel, and Bryan for catching and reporting the issue.

bcmills added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm64 labels Nov 12, 2020

bcmills added this to the Backlog milestone Nov 12, 2020

dmitshur mentioned this issue Nov 12, 2020

x/build/env/openbsd: add OpenBSD 6.8 builder #35712

Closed

dmitshur removed the arch-arm64 label Nov 13, 2020

dmitshur changed the title ~~os: nonzero exit status mishandled on openbsd/arm64~~ os: nonzero exit status mishandled on OpenBSD Nov 13, 2020

dmitshur mentioned this issue Dec 10, 2020

doc, x/build/dashboard: document Go 1.16 requires at least OpenBSD 6.4, drop OpenBSD 6.2 builders #42426

Closed

2 tasks

dmitshur changed the title ~~os: nonzero exit status mishandled on OpenBSD~~ os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch Jan 20, 2021

dmitshur closed this as completed Jan 22, 2021

golang locked and limited conversation to collaborators Jan 22, 2022

gopherbot added the FrozenDueToAge label Jan 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch #42542

os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch #42542

bcmills commented Nov 12, 2020

bcmills commented Nov 12, 2020

4a6f656c commented Nov 12, 2020

4a6f656c commented Nov 13, 2020

4a6f656c commented Nov 16, 2020

4a6f656c commented Dec 10, 2020

dmitshur commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 16, 2020

gopherbot commented Dec 18, 2020

gopherbot commented Dec 21, 2020

dmitshur commented Dec 22, 2020 •

edited

4a6f656c commented Jan 22, 2021

dmitshur commented Jan 22, 2021

os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch #42542

os: nonzero exit status mishandled on OpenBSD before 009_exit syspatch #42542

Comments

bcmills commented Nov 12, 2020

bcmills commented Nov 12, 2020

4a6f656c commented Nov 12, 2020

4a6f656c commented Nov 13, 2020

4a6f656c commented Nov 16, 2020

4a6f656c commented Dec 10, 2020

dmitshur commented Dec 10, 2020

gopherbot commented Dec 10, 2020

gopherbot commented Dec 16, 2020

gopherbot commented Dec 18, 2020

gopherbot commented Dec 21, 2020

dmitshur commented Dec 22, 2020 • edited

4a6f656c commented Jan 22, 2021

dmitshur commented Jan 22, 2021

dmitshur commented Dec 22, 2020 •

edited