Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: debug_line can contain multiple entries for the same PC address in Go 1.15.4 [1.15 backport] #42521

Closed
gopherbot opened this issue Nov 11, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@thanm requested issue #42484 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport issue for 1.15.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 11, 2020
@gopherbot gopherbot added this to the Go1.15.5 milestone Nov 11, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/269517 mentions this issue: [release-branch.go1.15] cmd/compile: do not emit an extra debug_line entry for the end of seq addr

@gopherbot
Copy link
Author

Change https://golang.org/cl/269518 mentions this issue: [release-branch.go1.15] cmd/compile: do not emit an extra debug_line entry for the end of seq addr

@cagedmantis cagedmantis modified the milestones: Go1.15.5, Go1.15.6 Nov 12, 2020
@dmitshur
Copy link
Contributor

Approved as this is a serious issue without a viable workaround. Only 1.15 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Nov 23, 2020
@gopherbot
Copy link
Author

Closed by merging 16ddb8b to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Nov 23, 2020
…entry for the end of seq addr

Uses DW_LNS_advance_pc directly, instead of calling putpclcdelta
because the latter will create a new debug_line entry for the end of
sequence address.

Updates #42484.
Fixes #42521.

Change-Id: Ib6355605cac101b9bf37a3b4961ab0cee678a839
Reviewed-on: https://go-review.googlesource.com/c/go/+/268937
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/269517
@golang golang locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants