Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gc: export info too big #4252

Closed
rsc opened this issue Oct 16, 2012 · 7 comments
Closed

cmd/gc: export info too big #4252

rsc opened this issue Oct 16, 2012 · 7 comments
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Oct 16, 2012

look at fmt.a
there's all this reflect stuff that shouldn't be there, at least.
@robpike
Copy link
Contributor

robpike commented Oct 17, 2012

Comment 1:

Also, what's this there for?
    var @"".statictmp_0722 [1]byte
    var @"".statictmp_0723 [4]byte
    var @"".statictmp_0724 [5]byte
    var @"".statictmp_0725 [2]byte
    var @"".statictmp_0726 [5]byte
    var @"".statictmp_0727 [5]byte
    var @"".statictmp_0728 [3]byte
    var @"".statictmp_0729 [4]byte
    var @"".statictmp_0730 [9]byte
    var @"".statictmp_0731 [7]byte
    var @"".statictmp_0732 [9]byte
    var @"".statictmp_0733 [2]byte
    var @"".statictmp_0734 [7]byte
    var @"".statictmp_0735 [12]byte
    var @"".statictmp_0736 [11]byte
    var @"".statictmp_0737 [10]byte
    var @"".statictmp_0738 [11][2]uint16

Labels changed: added priority-later, removed priority-triage.

@lvdlvd
Copy link

lvdlvd commented Dec 3, 2012

Comment 2:

the reflect stuff look like it is the transitive dependency of pp.fmtPointer and other
fmt functions that take a reflect.Value argument.  I don't see how those can be avoided.
the statictmps are added by sinit which calls addvar which calls declare which adds any
PEXTERN to the exportlist.  That is easy to avoid.

@remyoudompheng
Copy link
Contributor

Comment 3:

See CL 6856126. 
https://golang.org/cl/6856126/

@lvdlvd
Copy link

lvdlvd commented Dec 3, 2012

Comment 4:

... but the linker complains if declare doesn't put them on the exportlist, e.g.
.dynsym: text/template/parse.statictmp_0871(0): not defined
advice?

@lvdlvd
Copy link

lvdlvd commented Dec 3, 2012

Comment 5:

Oh sorry, i hadn't seen that you had picked this up.  never mind me.

@remyoudompheng
Copy link
Contributor

Comment 6:

Erm, where did you get that text/template/parse.statictmp_0871 message?

@remyoudompheng
Copy link
Contributor

Comment 7:

This issue was closed by revision 561edbd.

Status changed to Fixed.

@rsc rsc added fixed labels Dec 8, 2012
@rsc rsc self-assigned this Dec 8, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants