Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" #42518

Closed
eliben opened this issue Nov 11, 2020 · 2 comments
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite

Comments

@eliben
Copy link
Member

eliben commented Nov 11, 2020

What is the URL of the page with the issue?

http://localhost:8080/github.com/gin-gonic/gin

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Screenshot

ff

What did you do?

Press 'f' to jump to symbol, then select one of the identifiers

What did you expect to see? What did you see instead?

The jump works, but FireFox developer console prints out the error shown in the screenshot.

@gopherbot gopherbot added this to the Unreleased milestone Nov 11, 2020
@julieqiu
Copy link
Member

/cc @jamalc

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Nov 11, 2020
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 11, 2020
@julieqiu julieqiu changed the title x/pkgsite:uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" x/pkgsite: uncaught JS errors on FireFox -- "Failed to execute 'close' on dialog" Nov 11, 2020
@jamalc jamalc self-assigned this Nov 11, 2020
@jamalc
Copy link

jamalc commented Feb 18, 2021

Can't reproduce this one, it's possible we've fixed it already. Please re-open if its still happening.

@jamalc jamalc closed this as completed Feb 18, 2021
@golang golang locked and limited conversation to collaborators Feb 18, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants