Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: synthesize a go.sum file for multi-module workspaces #42509

Closed
findleyr opened this issue Nov 11, 2020 · 1 comment
Closed

x/tools/gopls: synthesize a go.sum file for multi-module workspaces #42509

findleyr opened this issue Nov 11, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
vscode-go: gopls by default
Milestone
gopls/v0.6.0

Comments

@findleyr
Copy link
Contributor

In https://golang.org/cl/268597, we're proactively switching to -mod=readonly for many go command invocations. Unfortunately, this breaks multi-workspace mode, because our multi-module workspace contains only a go.mod file.

We should track go.sum files as well, and merge them into a go.sum file for the workspace.
@findleyr findleyr self-assigned this Nov 11, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 11, 2020
@gopherbot gopherbot added this to the Unreleased milestone Nov 11, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 12, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 12, 2020
@gopherbot
Copy link

Change https://golang.org/cl/272886 mentions this issue: internal/lsp/cache: build a go.sum file for multi-module workspaces

@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Dec 3, 2020
vscode-go: gopls by default automation moved this from In progress to Done Dec 7, 2020
marwan-at-work pushed a commit to marwan-at-work/tools that referenced this issue Dec 23, 2020
@findleyr @marwan-at-work
internal/lsp/cache: build a go.sum file for multi-module workspaces
7368b8c 
When running with -mod=readonly, we need a go.sum to be present for go
command invocations. Achieve this by merging the go.sum of tracked
modules.

Fixes golang/go#42509

Change-Id: I36dd084f865ebcee0ba6e1e542fdf51031b1487e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/272886
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Trust: Robert Findley <rfindley@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@golang golang locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
gopls/v0.6.0
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr