Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add a second analysis diagnostics pass for changed files #42499

Closed
stamblerre opened this issue Nov 11, 2020 · 1 comment
Closed

x/tools/gopls: add a second analysis diagnostics pass for changed files #42499

stamblerre opened this issue Nov 11, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
vscode-go: gopls by default
Milestone
gopls/v0.6.0

Comments

@stamblerre
Copy link
Contributor

After the fix to avoid flashing diagnostics (https://golang.org/cl/267817), I now feel a noticeable lag when getting diagnostic results for files with no errors or with analysis errors. I think we should add a second pass that runs diagnostics with analyses on only the changed files, so that those results can come back before the diagnostics for the whole workspace.

/cc @findleyr
@stamblerre stamblerre added this to the gopls/v0.5.3 milestone Nov 11, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 11, 2020
@gopherbot
Copy link

Change https://golang.org/cl/269197 mentions this issue: internal/lsp: run analyses on changed files before full diagnostics

@stamblerre stamblerre modified the milestones: gopls/v0.5.3, gopls/v0.5.4 Nov 11, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.4, gopls/v0.6.0 Nov 24, 2020
vscode-go: gopls by default automation moved this from Critical to Done Dec 1, 2020
marwan-at-work pushed a commit to marwan-at-work/tools that referenced this issue Dec 23, 2020
@stamblerre @marwan-at-work
internal/lsp: run analyses on changed files before full diagnostics
c4b130f 
Without this, analysis diagnostics have to wait until the entire
workspace is analyzed, which has a noticeable latency.

Refactored diagnosePkg out of diagnose to reuse code, and cleaned up
the showMsg and seen file logic a little bit.

Fixes golang/go#42499

Change-Id: I51314dab156dce87dc19eba997c53d2aea428b6c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/269197
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
vscode-go: gopls by default
  
Done
Milestone
gopls/v0.6.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot