Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh/terminal: add support for zos #42496

Closed
mahdi-hm opened this issue Nov 10, 2020 · 2 comments
Closed

x/crypto/ssh/terminal: add support for zos #42496

mahdi-hm opened this issue Nov 10, 2020 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mahdi-hm
Copy link

mahdi-hm commented Nov 10, 2020 •
edited

As discussed in golang-dev, I would like to add the x/cyrpto/ssh/terminal package for s390x running zos. No changes should affect other platforms.
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2020
@gopherbot
Copy link

Change https://golang.org/cl/269177 mentions this issue: crypto/ssh/termianl: add support for zos/s390x

@tklauser tklauser changed the title x/crypto/ssh/termianl: add support for zos x/crypto/ssh/terminal: add support for zos Nov 11, 2020
@delusionwind
Copy link

I think // +build zos is needed in util_zos.go because it declares the same constant with util_linux.go

gopherbot pushed a commit to golang/term that referenced this issue Nov 13, 2020
@mahdi-hm @tklauser
ssh/terminal: add support for zos
c955d0b 
Fixes golang/go#42496

Change-Id: Iae2ddb916904d9b3947bec9638c9fbf892df7b7c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/269177
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Michael Munday <mike.munday@ibm.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Nov 13, 2021
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@mahdi-hm @tklauser
ssh/terminal: add support for zos
f4c70e2 
Fixes golang/go#42496

Change-Id: Iae2ddb916904d9b3947bec9638c9fbf892df7b7c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/269177
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Michael Munday <mike.munday@ibm.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@mahdi-hm @tklauser
ssh/terminal: add support for zos
e858dc7 
Fixes golang/go#42496

Change-Id: Iae2ddb916904d9b3947bec9638c9fbf892df7b7c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/269177
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Trust: Michael Munday <mike.munday@ibm.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @delusionwind @mahdi-hm