Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blog/content: images and embedded YouTube content in pkgsite-redesign.article renders poorly on mobile #42493

Open
davecheney opened this issue Nov 10, 2020 · 3 comments
Open

x/blog/content: images and embedded YouTube content in pkgsite-redesign.article renders poorly on mobile #42493

davecheney opened this issue Nov 10, 2020 · 3 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@davecheney
Copy link
Contributor

9B35A945-9D8A-4055-B602-0286395BC981

The recent blog post on pkg.go.dev renders poorly on mobile browsers.
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2020
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 13, 2020
@cagedmantis
Copy link
Contributor

/cc @dmitshur

@dmitshur
Copy link
Contributor

It looks like that particular blog post inlines some markup that isn't mobile-friendly.

For example, removing the hardcoded "height" attribute from <img> tags helps images scale gracefully as the viewport width becomes narrower than the original image size. Something similar needs to be done for the <iframe> that embeds the youtube video.

Perhaps some older blog posts can be used as reference. For example, https://blog.golang.org/go.dev embeds images in a mobile-friendly way. I didn't find blog posts that embed YouTube videos in a mobile-friendly way though (e.g., https://blog.golang.org/why-generics, https://blog.golang.org/fosdem14, https://blog.golang.org/go1-path, all have a similar problem at narrow widths).

CC @julieqiu.

@dmitshur dmitshur changed the title x/website: blog articles with images and embedded YouTube content render poorly on mobile x/blog/content: images and embedded YouTube content in pkgsite-redesign.article renders poorly on mobile Nov 13, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 13, 2020
@gopherbot
Copy link

Change https://golang.org/cl/270804 mentions this issue: content: fix images on mobile for pkgsite-redesign.article

gopherbot pushed a commit to golang/blog that referenced this issue Nov 17, 2020
@julieqiu
content: fix images on mobile for pkgsite-redesign.article
5d7660a 
The "height" attribute is removed from <img> tags so that images will
scale gracefully as the viewport width becomes narrower than the
original image size.

For golang/go#42493

Change-Id: I951a1d82a119f55d22cd564e871203d07a0a5f28
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270804
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@julieqiu
[x/blog] content: fix images on mobile for pkgsite-redesign.article
a6001ba 
The "height" attribute is removed from <img> tags so that images will
scale gracefully as the viewport width becomes narrower than the
original image size.

For golang/go#42493

Change-Id: I951a1d82a119f55d22cd564e871203d07a0a5f28
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270804
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Blog-Commit: 5d7660a8674f3c659ded6a2f49c151c26c5eb282
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] content: fix images on mobile for pkgsite-redesign.article
42765d9 
The "height" attribute is removed from <img> tags so that images will
scale gracefully as the viewport width becomes narrower than the
original image size.

For golang/go#42493

Change-Id: I951a1d82a119f55d22cd564e871203d07a0a5f28
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270804
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Blog-Commit: 5d7660a8674f3c659ded6a2f49c151c26c5eb282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@davecheney @cagedmantis @dmitshur @gopherbot