Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/blog: (Too?) Few links to go.dev from golang.org #42492

Closed
maxekman opened this issue Nov 10, 2020 · 7 comments
Closed

x/blog: (Too?) Few links to go.dev from golang.org #42492

maxekman opened this issue Nov 10, 2020 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@maxekman
Copy link

What version of Go are you using (go version)?

N/A

Does this issue reproduce with the latest release?

N/A

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Visited golang.org.

What did you expect to see?

Links on the front page to go.dev and/or pkg.go.dev.

What did you see instead?

No links, I really tried to find some. Not even in the blog post announcing the overhaul of pkg.go.dev, at least what I could see.

@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2020
@ALTree
Copy link
Member

ALTree commented Nov 10, 2020

I agree the first time pkg.go.dev is mentioned in https://blog.golang.org/pkgsite-redesign (3rd word of the first sentence) should probably be a link to it. It's less clear where (if) it should be mentioned on golang.org.

cc @julieqiu

@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 10, 2020
@ALTree
Copy link
Member

ALTree commented Nov 10, 2020

Oh and in the blog post, below, there's a bad html tag:

The main change is that the pkg.go.dev/<path> 

@julieqiu julieqiu added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Nov 17, 2020
@julieqiu julieqiu changed the title x/website: (Too?) Few links to go.dev from golang.org x/blog: (Too?) Few links to go.dev from golang.org Nov 17, 2020
@gopherbot
Copy link

Change https://golang.org/cl/270805 mentions this issue: content: add additional links to pkgsite-redesign.article

@julieqiu
Copy link
Member

Thanks for the suggestion!

I agree the first time pkg.go.dev is mentioned in https://blog.golang.org/pkgsite-redesign (3rd word of the first sentence) should probably be a link to it.

Agreed - I'll add a link to pkg.go.dev in the first reference in the article as well as some captions for the images with links.

Oh and in the blog post, below, there's a bad html tag:
The main change is that the pkg.go.dev/

I think that is intentional - see also #41586, which refers to that page as the "pkg.go.dev/ page". @ALTree let me know if I am missing something.

Links on the front page to go.dev and/or pkg.go.dev.

I think this is a separate issue that isn't related to https://blog.golang.org/pkgsite-redesign, so I'll leave this issue open for that suggestion.

@ALTree
Copy link
Member

ALTree commented Nov 17, 2020

I think that is intentional - see also #41586, which refers to that page as the "pkg.go.dev/ page". @ALTree let me know if I am missing something.

Oh, I see, you're using /<path> as a placeholder... I thought it was a misplaced xml tag, sorry for the confusion.

@julieqiu
Copy link
Member

No problem, thanks for clarifying!

gopherbot pushed a commit to golang/blog that referenced this issue Nov 17, 2020
A link is added to the first reference of pkg.go.dev in the
pkgsite-redesign.article. Captions with links to the page displayed are
also added.

For golang/go#42492

Change-Id: I8eb66b807d5179ea0e677951ba96119aeb0e4439
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270805
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
A link is added to the first reference of pkg.go.dev in the
pkgsite-redesign.article. Captions with links to the page displayed are
also added.

For golang/go#42492

Change-Id: I8eb66b807d5179ea0e677951ba96119aeb0e4439
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270805
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Blog-Commit: cb7bc91ae1ebf974657226a6b74ed77e8b73e3d8
@seankhliao
Copy link
Member

with everything merged into go.dev, this seems to be no longer relevant

passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
A link is added to the first reference of pkg.go.dev in the
pkgsite-redesign.article. Captions with links to the page displayed are
also added.

For golang/go#42492

Change-Id: I8eb66b807d5179ea0e677951ba96119aeb0e4439
Reviewed-on: https://go-review.googlesource.com/c/blog/+/270805
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
X-Blog-Commit: cb7bc91ae1ebf974657226a6b74ed77e8b73e3d8
@golang golang locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants