Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: going back a page loses context #42456

Closed
rogpeppe opened this issue Nov 9, 2020 · 2 comments
Closed

x/pkgsite: going back a page loses context #42456

rogpeppe opened this issue Nov 9, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@rogpeppe
Copy link
Contributor

rogpeppe commented Nov 9, 2020

What is the URL of the page with the issue?

I happened to be looking at https://beta.pkg.go.dev/github.com/autom8ter/machine, but it could be any page with a long description.

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36

What did you do?

I had expanded the (long) description and was half way through reading it, then clicked on a link in the description, which took me to a new page, then clicked the browser "Back" button.

This took me back to the original page, but the description had collapsed again, losing my context. I had to re-expand and scroll back down to find where I was before.

I'd expect the back button to take me back to exactly where I was previously so I could continue browsing the docs easily.
@gopherbot gopherbot added this to the Unreleased milestone Nov 9, 2020
@jba jba added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 9, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Nov 9, 2020
@gopherbot
Copy link

Change https://golang.org/cl/346430 mentions this issue: static/frontend/unit: keep readme expanded context after page navigation

@gopherbot
Copy link

Change https://golang.org/cl/346438 mentions this issue: static/frontend/unit: keep readme expanded context after page navigation

@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@golang golang locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@rogpeppe @hyangah @julieqiu @gopherbot @jba