Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, x/build/dashboard: document Go 1.16 requires at least OpenBSD 6.4, drop OpenBSD 6.2 builders #42426

Closed
2 tasks done
dmitshur opened this issue Nov 6, 2020 · 11 comments
Closed
2 tasks done

doc, x/build/dashboard: document Go 1.16 requires at least OpenBSD 6.4, drop OpenBSD 6.2 builders #42426

dmitshur opened this issue Nov 6, 2020 · 11 comments
Labels
Builders x/build issues (builders, bots, dashboards) Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD release-blocker Unfortunate
Milestone
Go1.16

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 6, 2020 •
edited

Based on investigation and discussion in #42237 and #42408, and past support policy discussion in #15227 (comment), we should drop OpenBSD 6.2 support from the upcoming Go 1.16 release. What's needed:

  • Disable openbsd-{386,amd64}-62 builders for Go 1.16 and newer.
  • Document in Go 1.16 release notes that Go 1.16 requires at least OpenBSD 6.4: "Go 1.15 was the last release that ran on OpenBSD 6.2. Go 1.16 requires OpenBSD 6.4 or newer."
    • Ideally we should say OpenBSD 6.7 or newer, but we don't have builders to back up such a claim (see x/build/env/openbsd: add OpenBSD 6.8 builder #35712), so I think this is the best we can say for now.
    • Ideally we would've pre-announced this earlier, like in Go 1.11 release notes. Unfortunately we didn't have the information we have now earlier.
    • This became unneeded because we were able to add an OpenBSD 6.8 builder and get it passing in time.
  • Update relevant golang.org/wiki pages as needed.

Please comment if you think this plan can be improved.

CC @golang/release, @ianlancetaylor, @4a6f656c, @prattmic, @bcmills.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker labels Nov 6, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Nov 6, 2020
@dmitshur dmitshur mentioned this issue Nov 6, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/268097 mentions this issue: cmd/dist: skip static testtls on OpenBSD 6.2 and earlier

@dmitshur
Copy link
Contributor Author

There seems to be agreement to move forward with this plan, so moving this issue to NeedsFix.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Nov 10, 2020
@dmitshur dmitshur self-assigned this Nov 10, 2020
@gopherbot
Copy link

Change https://golang.org/cl/268880 mentions this issue: dashboard: only run openbsd-{386,amd64}-62 builders on Go 1.15 and older

@dmitshur dmitshur mentioned this issue Nov 11, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/269577 mentions this issue: dashboard: add OpenBSD 6.8 builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 12, 2020
@dmitshur
dashboard: only run openbsd-{386,amd64}-62 builders on Go 1.15 and older
5f7fe5e 
For golang/go#42426.

Change-Id: Id8a87ef1952291e06f0076f27ae019bf7ef0e6a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/268880
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 12, 2020
@dmitshur
dashboard: add OpenBSD 6.8 builders
3a574da 
This change builds on top of CL 268297, using the updated env script
to build OpenBSD 6.8 images, and adding new builders that use them.

This has been tested with cmd/debugnewvm on a recent Go tip commit,
as well as Go 1.15.4 and 1.14.11 commits. It passed, although there
were also some failures seen. Once the builder is added, we'll know
the test results for a wider set of commits, and can decide how to
proceed from there.

Minimize the configuration to a bare minimum. Specifically, remove
MinCPUPlatform since setting it "Intel Skylake" was found not to
have a noticeable effect on the speed of the build compared to the
zero value:

	# With MinCPUPlatform = "Intel Skylake":
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	17m8.308s

	# With a zero MinCPUPlatform value:
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	16m28.518s

For golang/go#35712.
Updates golang/go#42426.

Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07
Reviewed-on: https://go-review.googlesource.com/c/build/+/269577
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@aclements aclements mentioned this issue Nov 19, 2020
Closed
@dmitshur
Copy link
Contributor Author

@4a6f656c It seems we're close to hopefully having the OpenBSD 6.8 builder working, given the update in #42542 (comment).

I'm a bit concerned that stating in the release notes that OpenBSD 6.4 is supported is in conflict with the policy agreed on in #15227. According to that policy, Go 1.16 should support OpenBSD 6.8 and 6.7, and not support older OpenBSD releases.

It was difficult to find what to say when this issue was filed because we didn't have an OpenBSD 6.8 builder at all back then, and 6.4 was our latest (hence the "unfortunate" label). Now that it's changed (assuming we get the 6.8 builder working well soon, before RC 1), I wonder how much emphasis we should put on 6.4 still being supported.

@dmitshur
Copy link
Contributor Author

We still need to resolve this by Go 1.16 final release, but to buy more time (e.g., to get #35712 completed), I don't think this needs to block beta 1, so I'll apply okay-after-beta1 label.

@dmitshur dmitshur added the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 10, 2020
@gopherbot
Copy link

Change https://golang.org/cl/277115 mentions this issue: dashboard: update OpenBSD 6.8 images with 009_exit syspatch

gopherbot pushed a commit to golang/build that referenced this issue Dec 11, 2020
@dmitshur
dashboard: update OpenBSD 6.8 images with 009_exit syspatch
fc1f3f8 
For golang/go#35712.
Updates golang/go#42542.
Updates golang/go#42426.

Change-Id: Ifbdd025b8d1708e715ba312c438f391e1aeaeff8
Reviewed-on: https://go-review.googlesource.com/c/build/+/277115
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Joel Sing <joel@sing.id.au>
@toothrot toothrot removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 17, 2020
@gopherbot
Copy link

Change https://golang.org/cl/279134 mentions this issue: dashboard: update OpenBSD 6.8 images with 009_exit syspatch, take 2

gopherbot pushed a commit to golang/build that referenced this issue Dec 18, 2020
@dmitshur
dashboard: update OpenBSD 6.8 images with 009_exit syspatch, take 2
c7c6787 
These images were regenerated after the fix in CL 278732.

For golang/go#35712.
Updates golang/go#42542.
Updates golang/go#42426.

Change-Id: Ib9c9dc316e4f68e7fed2cafe5400942a94ba8fd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/279134
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Joel Sing <joel@sing.id.au>
@gopherbot
Copy link

Change https://golang.org/cl/279512 mentions this issue: dashboard: promote OpenBSD 6.8 builders to be default

gopherbot pushed a commit to golang/build that referenced this issue Dec 23, 2020
@dmitshur
dashboard: promote OpenBSD 6.8 builders to be default
01e47d9 
The known issue with OpenBSD 6.8 builders appears to be resolved
via CL 278732 and CL 279134. Promote them to the primary OpenBSD
post-submit builders and TryBots.

Having test coverage from OpenBSD 6.8 and 6.4 builders gives us
us more confidence that Go works on supported OpenBSD versions
(which are 6.8 and 6.7 at this time, per past policy decision
in https://golang.org/issue/15227#issuecomment-293319876).

Reduce numTryTestHelpers from 5 to 4 based on some data from
golang.org/issue/37439 showing that going from 3 to 5 helpers
doesn't make a significant difference. We can adjust further
if we learn that OpenBSD TryBots become the bottleneck.

Fixes golang/go#35712.
For golang/go#42542.
For golang/go#42064.
Updates golang/go#42426.

Change-Id: Id2fa4be7c3161f89752c1428146846fe06ca63db
Reviewed-on: https://go-review.googlesource.com/c/build/+/279512
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor Author

It was difficult to find what to say when this issue was filed because we didn't have an OpenBSD 6.8 builder at all back then, and 6.4 was our latest (hence the "unfortunate" label). Now that it's changed (assuming we get the 6.8 builder working well soon, before RC 1), I wonder how much emphasis we should put on 6.4 still being supported.

Fortunately, we were able to get an OpenBSD 6.8 builder up and running (which uncovered some issues both in OpenBSD kernel and the Go project, but they've been resolved by now), and it is passing. Together with the OpenBSD 6.4 builder, we have more confidence that versions in between should be okay too.

The OpenBSD support policy covers the past two OpenBSD releases, which are 6.8 and 6.7 at this time. With the builders we now have, I don't think we need to say anything in the release notes about OpenBSD 6.2, since it's unsupported.

I updated https://golang.org/wiki/OpenBSD#building-from-source in wiki commit cb4b232b to say that Go 1.15.x is the final Go version that ran on OpenBSD 6.2-6.3, since we know Go 1.16 will not work correctly on it.

Closing as this is resolved now.

@gopherbot
Copy link

Change https://golang.org/cl/342896 mentions this issue: dashboard: remove openbsd-{386,amd64}-62 builders

gopherbot pushed a commit to golang/build that referenced this issue Aug 17, 2021
@cagedmantis
dashboard: remove openbsd-{386,amd64}-62 builders
6a8cf83 
This change removes the openbsd-{386,amd64}-62 builders and associated
hosts. They were only being used for Go 1.15 development, which has
now now concluded.

For golang/go#42426

Change-Id: I6398bf2cac7cdaa17537e3e04ead0b934bbe4220
Reviewed-on: https://go-review.googlesource.com/c/build/+/342896
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-OpenBSD release-blocker Unfortunate
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
5 participants
@toothrot @dmitshur @bcmills @gopherbot and others