Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRI HTTP method is missing #42419

Closed
OGKevin opened this issue Nov 6, 2020 · 3 comments
Closed

PRI HTTP method is missing #42419

OGKevin opened this issue Nov 6, 2020 · 3 comments
Labels
FrozenDueToAge

Comments

@OGKevin
Copy link

OGKevin commented Nov 6, 2020 •
edited

What version of Go are you using (go version)?

$ go version
go1.15

Does this issue reproduce with the latest release?

Yes

Details

According to this documentation: https://httpwg.org/specs/rfc7540.html#n-pri-method-registration about http/2 there is a new HTTP method introduced called "PRI". This method however is not listed in https://github.com/golang/go/blob/b7e0adfee28b516a0dcceb5ecf0e5a695b38c61f/src/net/http/method.go.

Is a PR to add this method to the list welcome?
@davecheney
Copy link
Contributor

No thank you. It is generally considered that those constants were unnecessary. If you want to assert the method is PRI, the literal constant "PRI" is both more compact and more descriptive.

@mdlayher
Copy link
Member

mdlayher commented Nov 6, 2020

Per Dave's response, I've also seen enough general disdain for these constants to feel pretty safe about closing this one out.

@mdlayher mdlayher closed this as completed Nov 6, 2020
@OGKevin
Copy link
Author

OGKevin commented Nov 6, 2020

Thats a shame. Thanks for the feedback 👍🏾.

@golang golang locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davecheney @mdlayher @gopherbot @OGKevin