Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used on linux/{amd64,ppc64le,...} #42402

Closed
laboger opened this issue Nov 5, 2020 · 7 comments
Closed

context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used on linux/{amd64,ppc64le,...} #42402

laboger opened this issue Nov 5, 2020 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@laboger
Copy link
Contributor

laboger commented Nov 5, 2020

What version of Go are you using (go version)?

$ go version
go version devel +63fd764502 Wed Nov 4 23:24:22 2020 +0000 linux/ppc64le
go version devel +34c09695db Thu Nov 5 15:16:57 2020 +0000 linux/amd64
Hangs on both. Didn't try any others.

Does this issue reproduce with the latest release?

Does not hang in go 11.5.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

cd context
go test -test.bench=Timeout -test.timeout=30m -test.count=100

What did you expect to see?

Benchmarks complete with benchmark timing output.

What did you see instead?

One of the Timeout benchmarks hangs and the benchmarks do not finish.
go test -test.bench=Timeout -test.timeout=30m -test.count=100
goos: linux
goarch: ppc64le
pkg: context
BenchmarkWithTimeout/concurrency=40-16 317062 3244 ns/op
BenchmarkWithTimeout/concurrency=40-16 318670 3236 ns/op
BenchmarkWithTimeout/concurrency=40-16 383541 3008 ns/op
BenchmarkWithTimeout/concurrency=40-16 372940 3123 ns/op
BenchmarkWithTimeout/concurrency=40-16 (stops here.... )
Same behavior on amd64.

Trying some earlier commits, I found one from early September that does not hang but more experiments needed.
@laboger
Copy link
Contributor Author

laboger commented Nov 5, 2020

I got this test to hang on one system without setting the timeout option.

@erifan
Copy link

erifan commented Nov 6, 2020

This is just the same issue with #42237

@erifan erifan closed this as completed Nov 6, 2020
@laboger laboger mentioned this issue Nov 11, 2020
Closed
@aclements aclements mentioned this issue Nov 11, 2020
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Nov 11, 2020 •
edited

Issue #42237 is about OpenBSD specifically, and it will be resolved with #42426.

Reopening this since this is about linux/amd64 and linux/ppc64le, so it should be investigated separately, although it may be related in some way.

@dmitshur dmitshur reopened this Nov 11, 2020
@dmitshur dmitshur changed the title context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used on linux/ppc64le Nov 11, 2020
@dmitshur dmitshur changed the title context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used on linux/ppc64le context: BenchmarkWithTimeout/concurrency tests hang if -test.timeout=30m used on linux/{amd64,ppc64le,...} Nov 11, 2020
@cagedmantis cagedmantis added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-ppc64x labels Nov 13, 2020
@cagedmantis cagedmantis added this to the Backlog milestone Nov 13, 2020
@cagedmantis
Copy link
Contributor

/cc @Sajmani @bradfitz

@bcmills
Copy link
Contributor

bcmills commented Nov 13, 2020

This probably has the same root cause as #42424.

@laboger
Copy link
Contributor Author

laboger commented Nov 13, 2020 •
edited

This is not happening for me with the latest master on ppc64le.
My testing shows that it was fixed by CL 267257 and as you suspected that means it was probably introduced by CL 232298.
Also verified amd64 is fixed with CL 267257.

@bcmills
Copy link
Contributor

bcmills commented Nov 16, 2020

@laboger, thanks for verifying!

@bcmills bcmills closed this as completed Nov 16, 2020
@golang golang locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@cagedmantis @dmitshur @bcmills @gopherbot @laboger @erifan