Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: -gcflags=-race causes panic #42396

Closed
cuonglm opened this issue Nov 5, 2020 · 8 comments
Closed

cmd/link: -gcflags=-race causes panic #42396

cuonglm opened this issue Nov 5, 2020 · 8 comments
Labels
FrozenDueToAge
Milestone
Go1.16

Comments

@cuonglm
Copy link
Member

cuonglm commented Nov 5, 2020

What version of Go are you using (go version)?

$ go version
go version devel +3ef8562c9c Thu Nov 5 02:48:05 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

$ cd "$(go1.15.3 env GOROOT)/src/strings"
$ go1.15.3 test -gcflags=-race .

What did you expect to see?

Friendly error messages like go1.14.x does:

# strings.test
type..eq.[6]string: relocation target runtime.racefuncenter not defined
type..eq.[6]string: relocation target runtime.raceread not defined
type..eq.[6]string: relocation target runtime.racefuncexit not defined
type..eq.[2]string: relocation target runtime.racefuncenter not defined
type..eq.[2]string: relocation target runtime.raceread not defined
type..eq.[2]string: relocation target runtime.racefuncexit not defined
type..eq.[3]string: relocation target runtime.racefuncenter not defined
type..eq.[3]string: relocation target runtime.raceread not defined
type..eq.[3]string: relocation target runtime.racefuncexit not defined
type..eq.[4]string: relocation target runtime.racefuncenter not defined
type..eq.[4]string: relocation target runtime.raceread not defined
type..eq.[4]string: relocation target runtime.racefuncexit not defined
type..eq.[10]string: relocation target runtime.racefuncenter not defined
type..eq.[10]string: relocation target runtime.raceread not defined
type..eq.[10]string: relocation target runtime.racefuncexit not defined
type..eq.[8]string: relocation target runtime.racefuncenter not defined
type..eq.[8]string: relocation target runtime.raceread not defined
type..eq.[8]string: relocation target runtime.racefuncexit not defined
strings.(*Builder).String: relocation target runtime.racefuncenter not defined
strings.(*Builder).String: relocation target runtime.raceread not defined
strings.(*Builder).String: relocation target runtime.racefuncexit not defined
/home/cuonglm/sdk/go1.14.10/pkg/tool/linux_amd64/link: too many errors
FAIL	strings [build failed]
FAIL

What did you see instead?

Panic on go1.15.x and tip:

# strings.test
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x51dbbb]

goroutine 1 [running]:
cmd/link/internal/loader.(*Loader).FuncInfo(0xc00061c000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/usr/local/go/src/cmd/link/internal/loader/loader.go:1900 +0x9b
cmd/link/internal/ld.(*stkChk).check(0xc000138e78, 0xc000138d08, 0x1, 0x0)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:2359 +0x130
cmd/link/internal/ld.(*stkChk).check(0xc000138e78, 0xc000138e60, 0x0, 0x0)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:2418 +0x585
cmd/link/internal/ld.(*Link).dostkcheck(0xc000115880)
	/usr/local/go/src/cmd/link/internal/ld/lib.go:2319 +0x2bc
cmd/link/internal/ld.Main(0x86f840, 0x20, 0x20, 0x1, 0x7, 0x10, 0x0, 0x0, 0x6da8bf, 0x1b, ...)
	/usr/local/go/src/cmd/link/internal/ld/main.go:254 +0xe65
main.main()
	/usr/local/go/src/cmd/link/main.go:68 +0x1dc
FAIL	strings [build failed]
FAIL
@mvdan
Copy link
Member

mvdan commented Nov 5, 2020

Out of curiosity, why do you use -gcflags=-race instead of just -race?

@thanm thanm self-assigned this Nov 5, 2020
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 5, 2020
@thanm thanm added this to the Go1.16 milestone Nov 5, 2020
@thanm
Copy link
Contributor

thanm commented Nov 5, 2020

I can take a look at this.

@cuonglm
Copy link
Member Author

cuonglm commented Nov 5, 2020 •
edited
Loading

Out of curiosity, why do you use -gcflags=-race instead of just -race?

Actually, what I did is -gcflags=-l -race, then I want to remove -gcflags=-l, but mis-typing enter :)

@bcmills bcmills changed the title cmd/go: -gcflags=-race causes panic cmd/link: -gcflags=-race causes panic Nov 5, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/267881 mentions this issue: cmd/link: report error if builtin referenced but not defined

@thanm
Copy link
Contributor

thanm commented Nov 5, 2020

Just FYI, with the fix I submitted to the linker, we no longer get the panic. The error message is slightly different from before however. Instead of "relocation target runtime.racefuncexit not defined" it will be an error of the form "reference to undefined builtin 'runtime.racefuncexit' from package ". Hope that is ok.

@thanm thanm removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 6, 2020
@jayconrod
Copy link
Contributor

@katiehockman and I ran into an error which I think might be caused by CL 267881. Specifically, we're trying to merge master into the dev.fuzz branch in CL 275448. The failure we're seeing is https://storage.googleapis.com/go-build-log/cffd0112/linux-amd64_018f19d1.log.

  • In misc/cgo/testshared, the TestTestInstalledShared test is failing.
  • TestMain copies a number of packages into a temporary GOROOT and installs with go install -buildmode=shared runtime sync/atomic. That writes pkg/linux_amd64_dynlink/libruntime,sync-atomic.so.
  • TestTestInstalledShared runs go test -linkshared sync/atomic, which fails with:
reference to undefined builtin "runtime.morestack_noctxt" from package "crypto/sha256"
  • In this CL, crypto/sha256 is imported indirectly by the test main generated by go test. So the presence of that package isn't surprising.
  • I've verified runtime.morestack_noctxt is present in pkg/linux_amd64_dynlink/libruntime,sync-atomic.so.

@thanm Any idea why this is happening? If it's helpful, I can try to make a more minimal test case in a new issue.

@thanm
Copy link
Contributor

thanm commented Dec 9, 2020

This looks like a slightly different problem from the original bug, I think it might make sense to file another issue. The CL in question is mainly there to convert a linker panic into a regular link error, whereas in this case it looks as though it should be possible for the link to succeed. I can pull your CL and try taking a closer look at it.

@thanm
Copy link
Contributor

thanm commented Dec 10, 2020

New issue filed with smaller repro: #43107

@golang golang locked and limited conversation to collaborators Dec 10, 2021
@rsc rsc unassigned thanm Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
5 participants
@jayconrod @mvdan @cuonglm @gopherbot @thanm