Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner/maintnerd/maintapi: improve heuristic for determining Go version in development #42377

Closed
dmitshur opened this issue Nov 4, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 4, 2020

Running maintq try-work currently reports entries like:

maintq $ go run . try-work
waiting: <
  project: "pkgsite"
  branch: "master"
  change_id: "I02c38d1b90b10514f4bf50f21e6709e8829718dd"
  commit: "0651daffe465fa7b5a73fdb66884e9fe26fbcef6"
  version: 2
  go_commit: "e1b305af028544e00a22c905e68049c98c10a1cc"
  go_commit: "ef3039e99d3413735d863d84347561003d63340e"
  go_commit: "162b65e05cec843b1a6bee493362f2a3046dba7b"
  go_branch: "master"
  go_branch: "release-branch.go1.15"
  go_branch: "release-branch.go1.14"
  go_version: <
    major: 1
    minor: 15
  >
  go_version: <
    major: 1
    minor: 15
  >
  go_version: <
    major: 1
    minor: 14
  >
>

Note that the Go release branches "release-branch.go1.15" and "release-branch.go1.14" correspond to Go versions 1.15 and 1.14, which is accurate. However, the branch "master" (commit e1b305a) is reported to be Go version 1.15. It should be Go 1.16.

We're currently relying on a very simple heuristic for determining the Go version of the "master" branch, which is to take the version of the latest Go release. A much better heuristic is to report that branch (and any other non-release branch, like "dev.link") to be Go X.(Y+1).

There's room for improvement to precision here by reading the internal/goversion package in the git tree (issue #42376), but as a smaller step let's just make the current simple heuristic better. This is a piece needed to make a Go 1.16+ TryBot added in #42341 work.

CC @golang/release.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 4, 2020
@dmitshur dmitshur added this to the Unreleased milestone Nov 4, 2020
@dmitshur dmitshur self-assigned this Nov 4, 2020
@gopherbot
Copy link

Change https://golang.org/cl/267677 mentions this issue: maintner/maintnerd/maintapi: adjust heuristic for tip version

@golang golang locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants