Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: Readdirnames(-1) changed nil-ness behavior #42367

Closed
rsc opened this issue Nov 3, 2020 · 1 comment
Closed

os: Readdirnames(-1) changed nil-ness behavior #42367

rsc opened this issue Nov 3, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@rsc
Copy link
Contributor

rsc commented Nov 3, 2020

It's unclear exactly which direction it changed, but something about one of the zero-length-slice-return cases in Readdirnames changed from nil to non-nil or vice versa and broke some picky tests inside Google.

There was no intent to change this behavior of Readdirnames, so it should be fixed. I will do that.
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 3, 2020
@rsc rsc added this to the Go1.16 milestone Nov 3, 2020
@rsc rsc self-assigned this Nov 3, 2020
@gopherbot
Copy link

Change https://golang.org/cl/267637 mentions this issue: os: avoid nil returns from Readdirnames, Readdir, ReadDir

@golang golang locked and limited conversation to collaborators Nov 4, 2021
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@rsc @gopherbot