Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reinitialize snapshot eagerly and asynchronously #42365

Open
stamblerre opened this issue Nov 3, 2020 · 1 comment
Open

x/tools/gopls: reinitialize snapshot eagerly and asynchronously #42365

stamblerre opened this issue Nov 3, 2020 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

Currently, reinitialization of a snapshot is done by the next request to need an initialized snapshot. We should probably do the reinitialization eagerly and asynchronously, while making sure that it is canceled whenever a new snapshot is created.
@stamblerre stamblerre added this to the gopls/vscode-go milestone Nov 3, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 3, 2020
@gopherbot
Copy link

Change https://golang.org/cl/267579 mentions this issue: internal/lsp/cache: reinitialize eagerly and asynchronously

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Needs Triage in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Nov 11, 2020
@stamblerre stamblerre removed this from Needs Triage in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot