Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: reconsider "-u=patch" changing the default to "@patch" for other arguments #42360

Open
bcmills opened this issue Nov 3, 2020 · 1 comment
Open

cmd/go: reconsider "-u=patch" changing the default to "@patch" for other arguments #42360

bcmills opened this issue Nov 3, 2020 · 1 comment
Labels
modules NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 3, 2020

In CL 167747, we implemented support for the @patch version query in go get for #26812, and made -u=patch imply @patch for positional arguments that do not specify any other version.

In retrospect, that behavior seems too subtle: it changes the meaning of one argument based on another, and the other argument might not even be explicit on the command line (for example, it could be set via GOFLAGS). We should reconsider that decision.

Perhaps when -u=patch is set we should require an explicit @version suffix for all arguments, so that it is clear whether the user means “upgrade the argument and patch its dependencies” or “patch the argument and its dependencies”.

CC @rsc @jayconrod @matloob
@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. modules labels Nov 3, 2020
@bcmills bcmills modified the milestones: Go1.17, Go1.16 Nov 3, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Nov 3, 2020

Tentatively milestoning to 1.16 due to the interaction with CL 263267.

@bcmills bcmills modified the milestones: Go1.16, Go1.17 Dec 8, 2020
@jayconrod jayconrod modified the milestones: Go1.17, Backlog May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
modules NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jayconrod @bcmills