New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: incorrectly identifies sub-module #42346
Comments
We could dedupe the list of nested modules and packages for a given page, and not list the nested module if it is a package in that module. On https://beta.pkg.go.dev/cloud.google.com/go@v0.71.0, |
@julieqiu I can help on this one. |
Thanks, @trongbq! |
I think that is not a good approach to solve this issue. This issue happens because somehow pkgsite falsely identified |
I don't think that this identification is incorrect, just that the information isn't necessarily useful in the directories section of cloud.google.com/go (https://pkg.go.dev/cloud.google.com/go#section-directories).
However, it is likely that most (if not all) users are looking for the version of compute/metadata in cloud.google.com/go. This is why I suggested deduping the list in #42346 (comment). This wouldn't cover the case where a nested module was deleted (for example, cloud.google.com/go/compute/metadata was deleted completely from cloud.google.com/go). That might be better addressed by #41321.
I'm not sure I see what change could be made in the worker to fix this issue. Would you mind elaborating on what you're thinking? |
@julieqiu Ah I see, my assumption was wrong, thank you for such a detailed explanation. |
Change https://golang.org/cl/276592 mentions this issue: |
What is the URL of the page with the issue?
https://pkg.go.dev/cloud.google.com/go?tab=subdirectories
Screenshot
What did you do?
Navigate to the page linked above.
What did you expect to see?
cloud.google.com/go/compute/metadata
NOT listed as a sub-module.What did you see instead?
cloud.google.com/go/compute/metadata
listed as a sub-module.It was it's own module at one point, but it is no longer and has not been for many releases.
The text was updated successfully, but these errors were encountered: