Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: can't jump-to-definition on embedded type alias #42254

Closed
findleyr opened this issue Oct 28, 2020 · 1 comment
Closed

x/tools/gopls: can't jump-to-definition on embedded type alias #42254

findleyr opened this issue Oct 28, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.4

Comments

@findleyr
Copy link
Contributor

Setup:

type T = struct{}

type S struct {
  T
}

var x T

Jump to definition works on the T from var x T, but not on the T embedded in S. I'm sure that this is due to the way go/types handles type aliases, but we should work around this in the syntax layer.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 28, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2020
@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 28, 2020
@gopherbot
Copy link

Change https://golang.org/cl/272186 mentions this issue: internal/lsp: fix godef for embedded type aliases

@golang golang locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.4
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr