Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: replace links to godoc.org in x/* repos #42251

Closed
findleyr opened this issue Oct 28, 2020 · 5 comments
Closed

x/pkgsite: replace links to godoc.org in x/* repos #42251

findleyr opened this issue Oct 28, 2020 · 5 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/godoc.org...

Comments

@findleyr
Copy link
Member

A number of packages within x/ repos still link to self-documentation hosted on godoc.org (for example: x/tools/cmd/stringer, x/tools/cmd/present). Given that the plan is to eventually redirect this traffic to pkg.go.dev (https://blog.golang.org/pkg.go.dev-2020), we should proactively update these links to point to pkg.go.dev.

CC @julieqiu
@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/264999 mentions this issue: cmd/fiximports,cmd/present,cmd/stringer: update documentation link to pkg.go.dev

@bcmills bcmills added the Documentation Issues describing a change to documentation. label Oct 28, 2020
gopherbot pushed a commit to golang/tools that referenced this issue Oct 30, 2020
@findleyr
cmd/fiximports,cmd/present,cmd/stringer: update links to pkg.go.dev
589136c 
These commands link to self-documentation hosted on godoc.org. Given
that this traffic will eventually be redirected to pkg.go.dev
(https://blog.golang.org/pkg.go.dev-2020), we should proactively update
them to pkg.go.dev.

For golang/go#42251

Change-Id: Iff1e4c6958d4e1ddff98150fae6b811e7764816a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/264999
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Robert Findley <rfindley@google.com>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/276033 mentions this issue: all: add or change GoDoc badge to pkg.go.dev manually

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/276032 mentions this issue: all: add or change GoDoc badge to pkg.go.dev with update-readmes.go

@julieqiu
Copy link
Member

julieqiu commented Dec 8, 2020

Related CLs:

https://go-review.googlesource.com/c/oauth2/+/276016
https://go-review.googlesource.com/c/tools/+/275235
https://go-review.googlesource.com/c/website/+/275195

@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 8, 2020
gopherbot pushed a commit to golang/build that referenced this issue Dec 15, 2020
@julieqiu
all: add or change GoDoc badge to pkg.go.dev with update-readmes.go
a56ae94 
update-readmes.go is updated to add a pkg.go.dev badge instead of a
godoc.org badge.

The GoDoc badge is added or changed in all READMEs by running
update-readmes.go

For golang/go#42251

Change-Id: I0c49df26a6c695f938c98c9a7b26325d991b3cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/276032
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Dec 15, 2020
@julieqiu
all: add or change GoDoc badge to pkg.go.dev manually
7ff1f94 
READMEs with a GoDoc badge that were not changed by update-readmes.go
are manually changed.

For golang/go#42251

Change-Id: Iaaa815e4a5f0905cfb20ea62fcb4cf2e75fde991
Reviewed-on: https://go-review.googlesource.com/c/build/+/276033
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@julieqiu
Copy link
Member

This should be fixed. Feel free to reopen if anything was missed.

adamhassel pushed a commit to adamhassel/stringer that referenced this issue Nov 19, 2021
@findleyr
cmd/fiximports,cmd/present,cmd/stringer: update links to pkg.go.dev
53b8b6d 
These commands link to self-documentation hosted on godoc.org. Given
that this traffic will eventually be redirected to pkg.go.dev
(https://blog.golang.org/pkg.go.dev-2020), we should proactively update
them to pkg.go.dev.

For golang/go#42251

Change-Id: Iff1e4c6958d4e1ddff98150fae6b811e7764816a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/264999
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Trust: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/godoc.org-redirect
Development

No branches or pull requests
5 participants
@bcmills @julieqiu @gopherbot @jamalc @findleyr