Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: unexpected test failure TestOverlayChangesPackageName #42234

Closed
katiehockman opened this issue Oct 27, 2020 · 3 comments
Closed

x/tools/go/packages: unexpected test failure TestOverlayChangesPackageName #42234

katiehockman opened this issue Oct 27, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@katiehockman
Copy link
Contributor

The TryBots are failing in https://go-review.googlesource.com/c/go/+/265078 on the TestOverlayChangesPackageName test, as well as other various gopls tests.

The full failure can be seen here: https://storage.googleapis.com/go-build-log/f32b11d4/linux-amd64_01b6165f.log

The error starts out:

--- FAIL: TestOverlayChangesPackageName (0.09s)
    --- FAIL: TestOverlayChangesPackageName/GOPATH (0.04s)
        overlay_test.go:45: failed to load: unsupported version of go: exit status 2: flag provided but not defined: -overlay
            usage: go list [-f format] [-json] [-m] [list flags] [build flags] [packages]
            Run 'go help list' for details.
    --- FAIL: TestOverlayChangesPackageName/Modules (0.06s)
        overlay_test.go:45: failed to load: unsupported version of go: exit status 2: flag provided but not defined: -overlay
            usage: go list [-f format] [-json] [-m] [list flags] [build flags] [packages]
            Run 'go help list' for details.

This is a one line CL which is just a revert to add a blank identifier import back into x509.go. Is there something wrong with the change, or is there something wrong with the test? I ran it twice and it failed both times, so it doesn't seem to be a flake.
@katiehockman katiehockman added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Oct 27, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Oct 27, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 27, 2020
@heschi
Copy link
Contributor

heschi commented Oct 27, 2020

Please rebase your CL. See https://go-review.googlesource.com/c/tools/+/263984/comment/db5f9e00_6448a8a7/.

@heschi
Copy link
Contributor

heschi commented Oct 27, 2020

@stamblerre

@katiehockman
Copy link
Contributor Author

Thanks, that resolved it.

@golang golang locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @heschi @katiehockman