Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: do not skip the cmd/go tests for linux/mips64le #42223

Closed
XiaodongLoong opened this issue Oct 27, 2020 · 7 comments
Closed

cmd/go: do not skip the cmd/go tests for linux/mips64le #42223

XiaodongLoong opened this issue Oct 27, 2020 · 7 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@XiaodongLoong
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.15.3 linux/mips64le

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_mips64le"
GCCGO="gccgo"
GOMIPS64="hardfloat"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/usr/local/go/src/cmd/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build999960069=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I run cmd/go tests on linux/mips64le platform, the cmd/go tests all skiped.

# go test -test.v cmd/go -run=Script/ -work -count=1
WORK=/tmp/go-build534713729 === RUN TestScript
script_test.go:42: skipping external tests on linux/mips64le
--- SKIP: TestScript (0.00s)
PASS
ok cmd/go 6.613s

What did you expect to see?

The cmd/go tests all can run and all get "PASS" result on linux/mips64le.

What did you see instead?
@ianlancetaylor ianlancetaylor changed the title cmd/go：do not skip the cmd/go tests for linux/mips64le cmd/godo not skip the cmd/go tests for linux/mips64le Oct 27, 2020
@ianlancetaylor ianlancetaylor changed the title cmd/godo not skip the cmd/go tests for linux/mips64le cmd/go: do not skip the cmd/go tests for linux/mips64le Oct 27, 2020
@ianlancetaylor
Copy link
Contributor

For the record, we started skipping them in https://golang.org/cl/33425. We skip them because the boards we were using are slow, and in general these tests act the same on all targets, so running them on multiple targets didn't help coverage.

But I think it would be reasonable to have some way to actually run them.

CC @bcmills @jayconrod

@ianlancetaylor ianlancetaylor added GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 27, 2020
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Oct 27, 2020
@ianlancetaylor ianlancetaylor added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 27, 2020
@XiaodongLoong
Copy link
Contributor Author

https://farmer.golang.org/builders#host-linux-mipsle-mengzhuo
The builder(host-linux-mipsle-mengzhuo) is a 3A4000(2.0Ghz/47 bit VMA) box and it runs well on Linux/mips64le by far. It seems enough for the architecture coverage.

https://groups.google.com/g/golang-dev/c/p_4y1rxhoe4/m/keSRwlYvAgAJ

@XiaodongLoong XiaodongLoong mentioned this issue Oct 27, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/265337 mentions this issue: cmd/go: cmd/go tests for linux/mips64le skiped

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 27, 2020
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 27, 2020
@cherrymui
Copy link
Member

The builder isn't fast enough that we want to run more tests on it. Also, as @ianlancetaylor said, it doesn't help much to enable this test on this particular builder.

I agree with @ianlancetaylor that there probably should be a way to actually run the test on demand.

@bcmills
Copy link
Contributor

bcmills commented Oct 28, 2020

I think the skipExternal = true cases in func init should be moved into the testenv.Builder() != "" condition.

I agree that we still don't want to run these tests on the Go project's builders, but we should not assume that our builders are the only ones running the tests on these platforms.

@bcmills
Copy link
Contributor

bcmills commented Oct 28, 2020

Or, at the very least, perhaps we should use skipExternal = testing.Short() instead of skipExternal = true. That way, users can indicate their willingness to wait via the -short flag.

@gopherbot
Copy link

Change https://golang.org/cl/265781 mentions this issue: cmd/go: use internal/testenv instead of computing canRun and skipExternal ad-hoc

@golang golang locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

cmd/go: run cmd/go tests for linux/mips64le
5 participants
@ianlancetaylor @bcmills @gopherbot @cherrymui @XiaodongLoong