Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: lock ordering problem involving sysmon and rwmutexR #42215

Closed
bcmills opened this issue Oct 26, 2020 · 2 comments
Closed

runtime: lock ordering problem involving sysmon and rwmutexR #42215

bcmills opened this issue Oct 26, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.16

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 26, 2020

https://build.golang.org/log/c75fff17cab7b8b13d7261ea3463955e9536eb8b

--- FAIL: TestExec (0.03s)
    exec_unix_test.go:255: 33555  ======
        0 : sysmon 1 0x6b4cf8
        1 : rwmutexR 30 0x6e6980
        fatal error: lock ordering problem
        
        runtime stack:
        runtime.throw(0x5a65af, 0x15)
        	/workdir/go/src/runtime/panic.go:1112 +0x72
        runtime.checkRanks(0xc000000900, 0x1, 0x1e)
        	/workdir/go/src/runtime/lockrank_on.go:159 +0x10c
        runtime.lockWithRank.func1()
        	/workdir/go/src/runtime/lockrank_on.go:87 +0xbc
        runtime.lockWithRank(0x6e6980, 0x1e)
        	/workdir/go/src/runtime/lockrank_on.go:76 +0xa5
        runtime.(*rwmutex).runlock(0x6e6980)
        	/workdir/go/src/runtime/rwmutex.go:70 +0xa9
        runtime.newm1(0xc000480000)
        	/workdir/go/src/runtime/proc.go:2005 +0xb5
        runtime.newm(0x0, 0xc000102800, 0xc)
        	/workdir/go/src/runtime/proc.go:1988 +0xa6
        runtime.startm(0x0, 0x0)
        	/workdir/go/src/runtime/proc.go:2196 +0xb4
        runtime.sysmon()
        	/workdir/go/src/runtime/proc.go:5002 +0x366
        runtime.mstart1()
        	/workdir/go/src/runtime/proc.go:1207 +0xc8
        runtime.mstart()
        	/workdir/go/src/runtime/proc.go:1172 +0x6e

I'm guessing this is another missing partial-order edge.

CC @danscales @mknyszek
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Oct 26, 2020
@bcmills bcmills added this to the Go1.16 milestone Oct 26, 2020
@danscales danscales self-assigned this Oct 26, 2020
@danscales
Copy link
Contributor

Thanks for filing this. I'll take a look and do the simple fix (assuming the partial order edge makes sense)

@danscales
Copy link
Contributor

Fixed by https://go-review.googlesource.com/c/go/+/265721

@golang golang locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@danscales @bcmills @gopherbot