Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dl: embed directive not working with gotip #42213

Closed
earthboundkid opened this issue Oct 26, 2020 · 2 comments
Closed

dl: embed directive not working with gotip #42213

earthboundkid opened this issue Oct 26, 2020 · 2 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@earthboundkid
Copy link
Contributor

What version of Go are you using (go version)?

$ gotip version
go version devel +c800222 Sun Oct 25 20:56:22 2020 +0000 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ gotip env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/Users/adhoc/bin"
GOCACHE="/Users/adhoc/Library/Caches/go-build"
GOENV="/Users/adhoc/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/adhoc/src/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/adhoc/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/adhoc/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/adhoc/sdk/gotip/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/var/folders/p7/jc4qc9n94r3f6ylg0ssh1rq00000gs/T/tmp.eGCNfh4R/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/p7/jc4qc9n94r3f6ylg0ssh1rq00000gs/T/go-build525352014=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run this:

example.txt: "abc123"

go.mod:

module example

go 1.16

example.go:

package main

import (
	"fmt"
	_ "embed"
)

func main() {
	//go:embed example.txt
	var x string
	fmt.Println(x)
}

What did you expect to see?

abc123

What did you see instead?

$ gotip run .
# example
./example.go:9:4: invalid go:embed: build system did not supply embed configuration

Is this just a temporary error as development proceeds, or does gotip need to be modified to work with embeds?
@ALTree
Copy link
Member

ALTree commented Oct 26, 2020 •
edited

Hi,

what makes you think the work on embed is completed?

For example this CL hasn't been merged yet, so I don't think you can expect embed to work on tip right now.

@ALTree ALTree added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 26, 2020
@earthboundkid
Copy link
Contributor Author

earthboundkid commented Oct 26, 2020 •
edited

Okay. Could just be too early then. I saw that the embed package is on tip and wanted to test it out. Will close until more CLs are closed.

@golang golang locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@earthboundkid @ALTree @gopherbot