Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys: TestFstatat failures on dragonfly-amd64 #42208

Closed
bcmills opened this issue Oct 26, 2020 · 3 comments
Closed

x/sys: TestFstatat failures on dragonfly-amd64 #42208

bcmills opened this issue Oct 26, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Dragonfly
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 26, 2020

TestFstatat appears to be flaky on the Dragonfly BSD builder:

--- FAIL: TestFstatat (0.00s)
    syscall_unix_test.go:674: Fstatat: returned stat does not match Stat
FAIL
FAIL	golang.org/x/sys/unix	1.885s

Since the test output is not particularly useful, it's not clear to me whether this is a bug in x/sys, in the test itself, or in the Dragonfly kernel.

2020-10-24T23:29:16-9f70ab9/dragonfly-amd64-5_8
2020-10-24T13:24:49-ef9fd89/dragonfly-amd64-5_8
2020-10-20T23:07:47-6e5568b/dragonfly-amd64-5_8
2020-10-18T23:04:17-eeed37f/dragonfly-amd64-5_8
2020-10-16T16:01:50-f659759/dragonfly-amd64-5_8
2020-10-14T08:05:44-cc95f25/dragonfly-amd64
2020-10-14T08:05:44-cc95f25/dragonfly-amd64-5_8
2020-10-06T15:56:30-ac719f4/dragonfly-amd64
2020-09-23T18:26:05-d9f96fd/dragonfly-amd64-5_8
2020-09-22T07:02:32-aee5d88/dragonfly-amd64-5_8
2020-09-18T17:44:21-af09f73/dragonfly-amd64
2020-09-18T17:44:21-af09f73/dragonfly-amd64-5_8
2020-09-17T07:31:48-efd3b9a/dragonfly-amd64-5_8
2020-09-16T08:47:44-dbad9cb/dragonfly-amd64-5_8
2020-08-28T19:40:41-157a740/dragonfly-amd64
2020-07-27T15:44:30-2d971f7/dragonfly-amd64-5_8
2020-07-20T21:16:30-cb9d2d5/dragonfly-amd64
2020-04-13T16:56:38-669c56c/dragonfly-amd64
2020-01-22T13:43:26-e047566/dragonfly-amd64
2020-01-22T13:43:26-e047566/dragonfly-amd64-5_6
2020-01-21T08:24:15-34d2753/dragonfly-amd64-5_6
2020-01-17T14:54:32-59e60aa/dragonfly-amd64-5_6
2019-12-23T22:40:30-abf886d/dragonfly-amd64-5_6
2019-12-20T22:00:14-0732a99/dragonfly-amd64
2019-12-20T22:00:14-0732a99/dragonfly-amd64-5_6
2019-12-20T14:29:24-d4481ac/dragonfly-amd64
2019-12-19T23:57:34-af0d71d/dragonfly-amd64
2019-12-19T23:57:34-af0d71d/dragonfly-amd64-5_6
2019-12-18T08:49:08-4a24b40/dragonfly-amd64-5_6
2019-12-10T02:34:23-ac6580d/dragonfly-amd64
2019-12-10T02:34:23-ac6580d/dragonfly-amd64-5_6
2019-12-06T22:06:18-eeba5f6/dragonfly-amd64
2019-12-06T21:42:22-bc7efcf/dragonfly-amd64
2019-12-04T07:23:24-ce4227a/dragonfly-amd64
2019-11-28T01:58:09-6d18c01/dragonfly-amd64
2019-11-27T02:17:46-63cb32a/dragonfly-amd64
2019-11-26T13:16:56-8a8471f/dragonfly-amd64
2019-11-20T15:59:48-bd43791/dragonfly-amd64
2019-11-19T06:07:38-e882bf8/dragonfly-amd64
2019-11-18T13:31:27-cf1e2d5/dragonfly-amd64
2019-11-18T01:35:47-6254a7c/dragonfly-amd64
2019-11-17T21:15:29-81af739/dragonfly-amd64
2019-11-15T15:19:21-52ab431/dragonfly-amd64
2019-11-13T16:50:36-4c7a9d0/dragonfly-amd64

CC @tklauser @tuxillo
@bcmills bcmills added OS-Dragonfly NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 26, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 26, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Oct 26, 2020

See previously #29401, #29447.

@tklauser
Copy link
Member

Thanks for the report, I guess this is due to some Stat_t fields changing between the unix.Stat and unix.Fstatat, e.g. Stat_t.Atim. I think we should compare only certain fields, like we do in the same test for the unix.Lstat result already. Will send a CL.

@gopherbot
Copy link

Change https://golang.org/cl/265018 mentions this issue: unix: compare Stat_t members when checking Stat vs. Fstatat in TestFstatat

@golang golang locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Dragonfly
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@tklauser @bcmills @gopherbot