Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/smtp: add optional Hello method #4219

Closed
bdaglish opened this issue Oct 9, 2012 · 5 comments
Closed

net/smtp: add optional Hello method #4219

bdaglish opened this issue Oct 9, 2012 · 5 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@bdaglish
Copy link

bdaglish commented Oct 9, 2012 

net/smtp is hardcoded to send "HELO localhost" and "EHLO localhost"
. This can cause blacklisting problems - see the "Identifying the Problem
Area" section of http://cbl.abuseat.org/namingproblems.html . This should probably
be configurable, defaulting to os.Hostname() if not specified.
@rsc
Copy link
Contributor

rsc commented Oct 9, 2012

Comment 1:

I don't believe we can change the default behavior now, nor do I believe it is
desirable. However, it would be fine to introduce an optional Hello method to override
the default of "localhost".
http://golang.org/cl/5555045 contains an implementation, and the comment thread
contains a long discussion about the choices. I hope someone will pick up that CL and
finish it, mainly by writing a test.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 2:

Labels changed: added size-m.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 3:

Labels changed: added suggested.

@gopherbot
Copy link

Comment 4 by rickarnoldjr:

Fixed by https://golang.org/cl/6946057/

@rsc
Copy link
Contributor

rsc commented Dec 17, 2012

Comment 5:

This issue was closed by revision 475dee9.

Status changed to Fixed.

@bdaglish bdaglish added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Dec 17, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
3 participants
@rsc @bdaglish @gopherbot