Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: trace of error response is missing #42157

Open
hyangah opened this issue Oct 22, 2020 · 0 comments
Open

x/tools/gopls: trace of error response is missing #42157

hyangah opened this issue Oct 22, 2020 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck
Milestone
gopls/backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 22, 2020

I triggered a codeAction that will fail and couldn't find the matching "Received response ..." from gopls trace.
The 'Error' entry is from vscode client (in response of the error reply) and doesn't include the message id. This makes it difficult for trace viewer to process the trace.

[Trace - 18:36:44.832 PM] Sending request 'textDocument/codeAction - (8)'.
Params: {"textDocument":{"uri":"file:///Users/hakim/hello/b.go"},"range":{"start":{"line":0,"character":1},"end":{"line":0,"character":1}},"context":{"diagnostics":[]}}

...
[Error - 6:36:44 PM] Request textDocument/codeAction failed.
  Message: no packages returned: packages.Load error
  Code: 0

The following is the corresponding trace recorded from the client side.

[Trace - 6:36:44 PM] Sending request 'textDocument/codeAction - (8)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/hakim/hello/b.go"
    },
    "range": {
        "start": {
            "line": 0,
            "character": 1
        },
        "end": {
            "line": 0,
            "character": 1
        }
    },
    "context": {
        "diagnostics": []
    }
}
...
[Trace - 6:36:44 PM] Received response 'textDocument/codeAction - (8)' in 39ms. Request failed: no packages returned: packages.Load error (0).
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 22, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 22, 2020
@findleyr findleyr self-assigned this Oct 23, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Critical to In progress in vscode-go: gopls by default Nov 10, 2020
@findleyr findleyr moved this from In progress to Non-critical in vscode-go: gopls by default Nov 11, 2020
@stamblerre stamblerre removed this from Non-critical in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
To Do
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @gopherbot @findleyr