Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: opaque struct pointers are broken since Go 1.15.3 [1.15 backport] #42151

Closed
gopherbot opened this issue Oct 22, 2020 · 3 comments
Closed

cmd/cgo: opaque struct pointers are broken since Go 1.15.3 [1.15 backport] #42151

gopherbot opened this issue Oct 22, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.4

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #42032 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport issue for 1.15.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 22, 2020
@gopherbot gopherbot mentioned this issue Oct 22, 2020
Closed
@gopherbot gopherbot added this to the Go1.15.4 milestone Oct 22, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/265719 mentions this issue: cmd/compile: fix storeType to handle pointers to go:notinheap types

@gopherbot
Copy link
Contributor Author

Closed by merging 068911e to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Oct 27, 2020
@randall77 @ianlancetaylor
[release-branch.go1.15] cmd/compile: fix storeType to handle pointers…
068911e 
… to go:notinheap types

storeType splits compound stores up into a scalar parts and a pointer parts.
The scalar part happens unconditionally, and the pointer part happens
under the guard of a write barrier check.

Types which are declared as pointers, but are represented as scalars because
they might have "bad" values, were not handled correctly here. They ended
up not getting stored in either set.

Fixes #42151

Change-Id: I46f6600075c0c370e640b807066247237f93c7ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/264300
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 933721b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/265719
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
@aykevl aykevl mentioned this issue Oct 27, 2020
Merged
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Nov 5, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 5, 2020
@petrjahoda
Copy link

With Go 1.15.4, it is fixed and tested

@golang golang locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.4
Development

No branches or pull requests
4 participants
@toothrot @randall77 @gopherbot @petrjahoda