Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/renameio: TestConcurrentReadsAndWrites flaky on ios-arm64-corellium builder #42066

Closed
bcmills opened this issue Oct 19, 2020 · 9 comments
Closed

cmd/go/internal/renameio: TestConcurrentReadsAndWrites flaky on ios-arm64-corellium builder #42066

bcmills opened this issue Oct 19, 2020 · 9 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 19, 2020

The ios-arm64-corellium builder seems to be affected by the same darwin kernel bug reported in #33041.

Perhaps we should expand the skip for that bug to also apply to ios-arm64-corellium, although it's not obvious to me how we could apply the skip to only the affected kernel.

CC @cherrymui @dmitshur

2020-10-17T00:26:52-a2eb53c/ios-arm64-corellium
2020-10-16T18:54:38-570b49d/ios-arm64-corellium
2020-10-12T17:23:06-1aa43a5/ios-arm64-corellium
2020-10-06T19:39:32-1fb149f/ios-arm64-corellium
@bcmills bcmills added OS-Darwin Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. mobile Android, iOS, and x/mobile labels Oct 19, 2020
@bcmills bcmills added this to the Go1.16 milestone Oct 19, 2020
@bcmills bcmills changed the title cmd/go/internal/renameio: TestConcurrentReadsAndWrites failure on ios-arm64-corellium builder cmd/go/internal/renameio: TestConcurrentReadsAndWrites flaky on ios-arm64-corellium builder Oct 19, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Oct 19, 2020 •
edited

Also CC @eliasnaur. Any idea if the darwin kernel issue can be resolved on the side of the builder?

@gopherbot
Copy link

Change https://golang.org/cl/263777 mentions this issue: cmd/go/internal/renameio: include ios in the darwin test-flake mitigation

@eliasnaur
Copy link
Contributor

The Corellium devices are both iOS 13.1.2. It just so happens that Corellium will move to the Amazon cloud on October 26, after which I have to re-create the devices; I'll see whether iOS 14 is available by then (I can't check without having free CPU cores available)

gopherbot pushed a commit that referenced this issue Oct 20, 2020
cmd/go/internal/renameio: include ios in the darwin test-flake mitiga…
f62d320 
…tion

Because the "ios" build constraint implies "darwin", it is already
included in the general "darwin" flakiness workaround in
cmd/go/internal/robustio. We just need to relax the renameio test
to avoid false-positives there.

I do not expect this change to drive the rate of false-positives down
to zero, but it should at least reduce noise on the build dashboard.

For #42066

Change-Id: Ia33dbd33295fce5b3261b4831f2807ce29b82e65
Reviewed-on: https://go-review.googlesource.com/c/go/+/263777
Trust: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented Oct 20, 2020

Unmarking as release-blocker because the mitigation is in: the test is likely still flaky but the rate should be low enough not to interfere with building releases.

@bcmills bcmills modified the milestones: Go1.16, Backlog Oct 20, 2020
@eliasnaur
Copy link
Contributor

The new Corellium infrastructure has iOS 14.1 available, but it seems unstable:

https://build.golang.org/log/64991503073e69146f7e4b8f47199fd36694d119
https://build.golang.org/log/615269dcecc2a85b76c460bd80760f73e4c1d76b
https://build.golang.org/log/85f76a0bec542a7325494c8bce1a9533feeb7617
https://build.golang.org/log/482cdb1f3e56a18329d3e676d5791b00f62bb5bd

I'm keeping the iOS 13 builders for now.

@glock47
Copy link

glock47 commented Oct 27, 2021

Also CC @eliasnaur. Any idea if the darwin kernel issue can be resolved on the side of the builder?

@eliasnaur
Copy link
Contributor

I'm no longer the maintainer of the builders. I believe @changkun was slated to take over.

@changkun
Copy link
Member

I could take over the builders and take a further look at this, although it seems the transfer is still in progress.

@changkun
Copy link
Member

I think we haven't seen this flaky for quite some time since iOS 14 builders are live. Corellium builders have many other issues which are slowly fixing. Let's close this for now. If it happens again, we could reopen it.

@golang golang locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@eliasnaur @dmitshur @bcmills @changkun @gopherbot @glock47