Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections #42063

Closed
bcmills opened this issue Oct 19, 2020 · 3 comments
Closed

x/build/cmd/coordinator: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections #42063

bcmills opened this issue Oct 19, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 19, 2020

The openbsd-mips64-jsing builder is greyed out on the dashboard for the main repo, and for the x/net repo in isolation.
image

However, its entry is not greyed out for the x/net repo in the golang.org/x/ repos summary section, where it shows as a red failure.
image

CC @golang/osp-team
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 19, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 19, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 19, 2020
@dmitshur
Copy link
Contributor

The feature of graying out a builder with a known issue has been implemented in x/build/app/appengine but only for the main section. It should be grayed out in the golang.org/x repository sections as well, that work hasn't been done yet. It's a matter of modifying the templates and data passed to incorporate this additional axis of information.

This can be fixed directly in x/build/app/appengine (sooner, but duplicate work), or wait for #34744 to be completed where this work has already been started.

@dmitshur dmitshur changed the title x/build/dashboard: openbsd-mips64-jsing inconsistently greyed out x/build/app/appengine: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections Oct 19, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 19, 2020
@dmitshur dmitshur self-assigned this Dec 8, 2021
@dmitshur dmitshur added this to In Progress in Go Release Team Dec 8, 2021
@dmitshur dmitshur changed the title x/build/app/appengine: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections x/build/cmd/coordinator: builders with non-zero KnownIssue are not grayed out in the golang.org/x repo sections Dec 8, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Dec 8, 2021

Now that #34744 is complete, this became much easier. Fix for this and another issue incoming.

@gopherbot
Copy link

Change https://golang.org/cl/370334 mentions this issue: cmd/coordinator: consistently dim columns for builders with known issue

Go Release Team automation moved this from In Progress to Done Dec 9, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot