Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Source links lead to invalid branch ids #42038

Closed
amlinux opened this issue Oct 17, 2020 · 1 comment
Closed

x/pkgsite: Source links lead to invalid branch ids #42038

amlinux opened this issue Oct 17, 2020 · 1 comment
Labels
FrozenDueToAge pkgsite
Milestone
Unreleased

Comments

@amlinux
Copy link

amlinux commented Oct 17, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/google.golang.org/grpc/status

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36

Screenshot

image

What did you do?

Clicked on the outlined links

What did you expect to see?

Source code at https://github.com/grpc/grpc-go/blob/master/status/status.go#L100

What did you see instead?

404 page at https://github.com/grpc/grpc-go/blob/v1.33.0/status/status.go#L100

Note "v1.33.0" that doesn't exist.
@gopherbot gopherbot added this to the Unreleased milestone Oct 17, 2020
@jba
Copy link
Contributor

jba commented Oct 20, 2020

It seems that grpc deleted a tag. pkg.go.dev knows about v1.33.0, as does the proxy:

> curl $GOPROXY/google.golang.org/grpc/@v/v1.33.0.info
{"Version":"v1.33.0","Time":"2020-10-08T18:59:09Z"}

But it's not on the repo.

I don't think we should try to work around this case. It shouldn't happen (you're not supposed to delete tags), and if it does it should be short-lived, until a new release is published. (To be clear, a new release will fix the problem for the default, latest-version page, but the source links on the v1.33.0 will be broken until the tag is re-created.)

This case is another argument against the way we currently do source linking. See #39559 for more on that.

@jba jba closed this as completed Oct 20, 2020
@golang golang locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@amlinux @gopherbot @jba