Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/objdump: TestDisasmExtld fails with "no runtime.symtab symbol found" on AIX #42025

Closed
dmitshur opened this issue Oct 16, 2020 · 2 comments
Closed

cmd/objdump: TestDisasmExtld fails with "no runtime.symtab symbol found" on AIX #42025

dmitshur opened this issue Oct 16, 2020 · 2 comments
Labels
arch-ppc64x FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-AIX Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16

Comments

@dmitshur
Copy link
Contributor

On the aix-ppc64 builder:

--- FAIL: TestDisasmExtld (2.79s)
    objdump_test.go:157: Running [/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go build -o /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestObjDump382551457/hello-b8671a8435298d43c67d864e10c70b6b.exe -ldflags=-linkmode=external fmthello.go]
    objdump_test.go:210: Running [/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestObjDump382551457/testobjdump.exe -s main.main /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestObjDump382551457/hello-b8671a8435298d43c67d864e10c70b6b.exe]
    objdump_test.go:214: objdump "fmthello.exe": exit status 1
        objdump: disassemble /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/TestObjDump382551457/hello-b8671a8435298d43c67d864e10c70b6b.exe: no runtime.symtab symbol found
FAIL
FAIL	cmd/objdump	4.421s

(Source: https://build.golang.org/log/ba1d49d26254c0260ab1e229800f45ad6768ee55.)

This looks related to #40972, CL 262779, and CL 263137.

CC @cherrymui @Helflym.
@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX arch-ppc64x labels Oct 16, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Oct 16, 2020
@cherrymui
Copy link
Member

Thanks. In CL 263137 I refactored the skipping logic. The old code skips TestDisasmExtld for PPC64, with a comment that it doesn't support external linking. I replaced it with MustHaveCGO (which covers external linking). But on AIX/PPC64, which does support cgo and external linking, the test needs to be skipped for a different reason. I'll update.

@gopherbot
Copy link

Change https://golang.org/cl/263147 mentions this issue: cmd/objdump: skip TestDisasmExtld on AIX

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 16, 2020
@golang golang locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-ppc64x FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-AIX Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @cherrymui