Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: fallocate_test.go:46: unexpected disk usage: got 1 blocks, want 2048 #42005

Closed
wheelcomplex opened this issue Oct 15, 2020 · 9 comments
Closed

cmd/link: fallocate_test.go:46: unexpected disk usage: got 1 blocks, want 2048 #42005

wheelcomplex opened this issue Oct 15, 2020 · 9 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Backlog

Comments

@wheelcomplex
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version devel +7602d41196 Thu Oct 15 23:12:53 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?

no reproduced in go-1.14.4

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/david/home/.cache/go-build"
GOENV="/home/david/home/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/david/sandspace/pkgextgo/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/david/sandspace/pkgextgo/"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/home/david/sandspace/go"
GOSUMDB="sum.golang.org"
GOTMPDIR="/home/david/sandspace/tmp"
GOTOOLDIR="/home/david/sandspace/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/home/david/sandspace/tmp/go-build907894934=/tmp/go-build -gno-record-gcc-switches"

What did you do?

compile Go from source: cd src && ./all.bash

What did you expect to see?

ALL TESTS PASSED

What did you see instead?

ok  	cmd/link/internal/benchmark	0.086s
--- FAIL: TestFallocate (0.00s)
    fallocate_test.go:61: unexpected disk usage: got 1 blocks, want 2048
    fallocate_test.go:61: unexpected disk usage: got 1 blocks, want 4096
    fallocate_test.go:61: unexpected disk usage: got 1 blocks, want 6144
FAIL
FAIL	cmd/link/internal/ld	5.307s

What did you figured out:

openZFS 2.0 reports fallocate is supported, but actaully not.

This should be a bug in openZFS 2.0, but we can workaround.

An improvement for The old issuse will follows up.
@gopherbot
Copy link

Change https://golang.org/cl/262837 mentions this issue: cmd/link: TestFallocate fallocate_test error #42005

@wheelcomplex wheelcomplex mentioned this issue Oct 16, 2020
Closed
@toothrot
Copy link
Contributor

/cc @cherrymui @rsc @mdempsky @ianlancetaylor

@toothrot toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 16, 2020
@toothrot toothrot added this to the Backlog milestone Oct 16, 2020
@cherrymui
Copy link
Member

Already commented on the CL.

As @wheelcomplex mentioned, this is an OS bug.

@IvanVolosyuk
Copy link

With transparent compression on filesystem level number of blocks can be non-deterministic in this test.

@wheelcomplex
Copy link
Contributor Author

ZFS 2.0 has released and currently behavior is intended. The CL has been updated to address this.

@cherrymui cherrymui mentioned this issue Dec 8, 2021
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
davepacheco pushed a commit to davepacheco/go that referenced this issue Nov 14, 2022
@wheelcomplex @davepacheco
cmd/link: TestFallocate fallocate_test error golang#42005
c9d0c6f 
Basic fallocate(mode=0/2) compatibility has been added in openZFS 2.0.

Test case TestFallocate has been suggested to skip on ZFS (openzfs/zfs#11073).

fix: golang#42005

Change-Id: Ic7ea6cbcb076c8e422c4136950b5e1f2c034955c
davepacheco pushed a commit to davepacheco/go that referenced this issue Dec 21, 2022
@wheelcomplex @davepacheco
cmd/link: TestFallocate fallocate_test error golang#42005
9aff57d 
Basic fallocate(mode=0/2) compatibility has been added in openZFS 2.0.

Test case TestFallocate has been suggested to skip on ZFS (openzfs/zfs#11073).

fix: golang#42005

Change-Id: Ic7ea6cbcb076c8e422c4136950b5e1f2c034955c
This was referenced Mar 31, 2023
Closed
Closed
@cherrymui
Copy link
Member

Sorry for the delay. Sounds like ZFS 2.0 has fixed the issue? Do we need to do anything more on this? Thanks.

@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Apr 3, 2023
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gl-yziquel
Copy link

I'm on zfs-2.1.5-1ubuntu6~22.04.2.

I still see this behaviour. I'd suggest reopening this bug.

@gl-yziquel
Copy link

Hmmhhh... no. I also get it when on an ext4 filesystem. Weird. When building go 1.21.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@toothrot @wheelcomplex @bcmills @IvanVolosyuk @gopherbot @cherrymui @gl-yziquel