x/tools/gopls: some properties/defaults from gopls api-json are invalid
#41964
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
gopherbot
added
Tools
|
Change https://golang.org/cl/262345 mentions this issue: |
|
Change https://golang.org/cl/262351 mentions this issue: |
|
Change https://golang.org/cl/262353 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Oct 15, 2020
Fix a few settings whose documentation was bad in various ways: - semanticTokens' was not camel case; changed to semanticTokens. - experimentalPackageCacheKey was not hooked up to a setting; do so. - literalCompletions is for tests only; hide it. - completionBudget should be specified as a duration string, not number of nanoseconds. - experimentalDiagnosticsDelay should have been affected similarly to completionBudget but is not mentioned in the bug. env is next. Updates golang/go#41964. Change-Id: I3470958cbdfc46daa76da297fc1a56da4a3f10ce Reviewed-on: https://go-review.googlesource.com/c/tools/+/262345 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Oct 15, 2020
Every setting parse error should include the name of the error for user sanity. Add it in the errorf method, clean up redundancy, and make existing errors more consistent/correct. Updates golang/go#41964. Change-Id: I8f980ceb5d82d4238edcd4095ea0e9572ac9c271 Reviewed-on: https://go-review.googlesource.com/c/tools/+/262353 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
But reproducible with the latest stable version of gopls (
gopls settings-json).Configure the vscode
goplssection with the default values listed in settings.md@64a9e34See gopls complaining about the default values and triggering multiple notification popups.
Issues:
semanticTokens,experimentalPackageCacheKey,literalCompletionswere unexpectedcompletionBudgetistime.Durationtype. The default value100000000is interpreted as float64. I tried to supply"100000000"(string type) which still fails due to parsing error (Params: {"type":1,"message":"failed to parse duration \"100000000\": time: missing unit in duration \"100000000\""})Note: the error message does not include the property name which needs to be addressed too.
envsection is defined as[]stringfollowingsource.UserOptions.EnvIn VS Code, environment variable collection is often
map[string]stringtype, so string array type is unusual.And,
goplsdoesn't accept default[]but accepts{}.The text was updated successfully, but these errors were encountered: