x/tools/go/analysis/passes/composite: false positive with gollvm #41918
Labels
Analysis
Issues related to static analysis (vet, x/tools/go/analysis)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Hi.
I was trying to build Delve - and caught this error.
go version go1.15.2 gollvm LLVM 12.0.0git linux/amd64
gollvm
My release build
go env
$ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/oceanfish81/.cache/go-build" GOENV="/home/oceanfish81/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/home/oceanfish81/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/oceanfish81/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/oceanfish81/gollvm_dist" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/oceanfish81/gollvm_dist/tools" GCCGO="/home/oceanfish81/gollvm_dist/bin/llvm-goc" AR="ar" CC="/usr/bin/clang" CXX="/usr/bin/clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build841452971=/tmp/go-build -gno-record-gcc-switches -funwind-tables"Right after cloning from the master branch:
github.com/go-delve/delve/pkg/proc
pkg/proc/eval.go:653:9: conversion from int64 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
github.com/go-delve/delve/pkg/proc_test
pkg/proc/proc_test.go:32:24: github.x2ecom/go-delve/delve/pkg/proc.LoadConfig composite literal uses unkeyed fields
pkg/proc/proc_test.go:2656:33: github.x2ecom/go-delve/delve/pkg/proc.LoadConfig composite literal uses unkeyed fields
make: *** [Makefile:19: vet] Error 2
CC @alandonovan @matloob
CC @polinasok @aarzilli @derekparker @epipho @chainhelen
The text was updated successfully, but these errors were encountered: